From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7051F33B946 for ; Tue, 21 Oct 2025 15:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761061383; cv=none; b=a/gmBIaGq65AH1isnXQl1snDwBLwClvU7/DjmjenAcPC/hf9ZTsoCIRnjvZRmpWQ0Ex8RMenzFJhvA6aEbafLr8NbCaVqfZN7fY4ctaOex35XjrpJZYqy6RbLyYKj4IqFRknToh/EOONXCFI4/ELZxwUZUUVs3Az4x+giwUZB8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761061383; c=relaxed/simple; bh=75YAXkRpS5AYEhu5CiBSWx6SM3C/ihZP1jjcOFswJjQ=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Px0GrEktfcvt5MkN8cLiUGOsDGNWooJzJuXGQMo4pdsm/hkodfv+FITZ/unevAGNyjIDzOeuvq000unG0KVcf0CKDmopaKBUjBFyTj8HPeltKg8JAbegDL+fsb2n7FSf2eEbhp1IuqcmbJPBRwqQ2LIDYPMda9GhvbkJuDFPwnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ryuKTo8W; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ryuKTo8W" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-474975af41dso7820525e9.2 for ; Tue, 21 Oct 2025 08:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761061379; x=1761666179; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AhuCz+PGVZVkdCu2Fi23G6TX91sa3helKlTwcjtnmzg=; b=ryuKTo8WANBP2UwKrgzWZgGqU2v43XPXv1l01txN1LTT3+xHVQnLWTKPVrJaP8iamT FuehqICTzqWuU1cfq7yptj/g/C2ZBKv5PDdADz+olNq/oKYwzOIUIlh1bOG8+whT1CdQ GEctkBKY53F5GxoBqeYyhq948ZTzOC94fQNEboUHfgSJVVtjvCDZYVMH1iKr5AsOPbtz VEg/cVrR6Nqde3Slst1tffnTbUC11fiWQ3LvUr07R1OX4UMDkXdNFoWGQ+hzyDgVuQxB niuzsHCAREJ/BLpkQX3fX7lGh0lueEkUj9iHF44t47qChuUtAcny3w9cpU/C6B5CjpIM 6vPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761061379; x=1761666179; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AhuCz+PGVZVkdCu2Fi23G6TX91sa3helKlTwcjtnmzg=; b=TT73BgOXLnRDZNEB7C3RTUPIYZRo22LAEIg5/9Uw0h1ZnNe5PolFCOHANzEMyHIXf9 FXVxTtRkkD7dYHOwhULRVl5kNCRA+h1+XFcGXtypoompk7HMtEE47579qRdVnuyE/JRu 7ZOlFTXCg6fVCcYxIxBtgeLJsLqgjUa7WQIwEpRicoGwsvQyuK+eQe3ApLVV9RhOZFua V3MVukNOq3s3YwNk5T4WNe9TAW/b2KHsILR7EfoqfjNxwlXJB3wg6utWyEO6/jeRlaMH 28LPrkhh4S3pOi/GpFxv1z2PMHO1CluvIQTKswvmlOfj7B5at/X4FmT0rurOemND5Yul St2Q== X-Forwarded-Encrypted: i=1; AJvYcCW7JFLoZbZSWRBXUyUJA9cJin7jISs6Ll0L+dsWdap85/PniuOsn/YBEF9Vy/2pyZTKQDxrvUBMwl/zAw==@vger.kernel.org X-Gm-Message-State: AOJu0Yxn9BNaV+f4E9BInuaeRvksJAlP6306zfoMi//CKB3VDCwYW4SJ AdHZaZhD2aCsnZ7TFHiozigbr4kZ02cv1OA/cmUFv2DbtdU9X7UemCXgYASSIgZzIe0= X-Gm-Gg: ASbGncvYkbnSiIpX5PhOiMcXsc+h8kajJtkvVXOr4k8FruNSNXsv+wZLdxxAD1Qu+3y daccJQnD1v7a7nhCRJMsmNv5pjndTuFdBylkDJXtc6JkMus6U+ZyBFW2w+2I+LbAYdRE+B9MoIl lokDw8/6Aquws5fHcZkEVPuGkLAU8VtP9+vux4Se/9kVpITFuecDyVZ3QLDYu9NEVDF4rtIQKFs fgyXAOptcL2TtvyaRSl7qQY7ZFu2Ew5DkRU2DeYwZqb5MmTOFJi8wV83n2jaBPW0SfDcVR0LIIs cyoS353F4NtOMs8/gazQd40mIMCC3WLfomdt4+VeOz6QPpNpGZY4SbYQCCmo6k7nPQfrj49lMsP EkAo4XrPzYlBlnYAIEor/pqg1FDwdG937q5M+S1nJPTWRSVmma6+uhY/x+maxqwbipT3S1b9aJy WT27RbPY7shxFQAB8= X-Google-Smtp-Source: AGHT+IHp7MSIsvZ3s51V1ZsAKBgYboS1prMkRndq+IeFpziSbp+//AH/rUos6US1MvtXcjHxE4wiZw== X-Received: by 2002:a05:600c:1d9b:b0:46e:652e:16a1 with SMTP id 5b1f17b1804b1-47117878458mr130704545e9.7.1761061378667; Tue, 21 Oct 2025 08:42:58 -0700 (PDT) Received: from localhost ([2a02:c7c:7259:a00:8d4e:2f09:764b:8b5a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-474949dd479sm21881025e9.0.2025.10.21.08.42.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 08:42:58 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 21 Oct 2025 16:42:57 +0100 Message-Id: Cc: "Bjorn Andersson" , "Konrad Dybcio" , "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Konrad Dybcio" , "Srinivas Kandagatla" , , , , , Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: qcm2290: add LPASS LPI pin controller From: "Alexey Klimov" To: "Dmitry Baryshkov" X-Mailer: aerc 0.20.0 References: <20251007-rb1_hdmi_audio-v2-0-821b6a705e4c@linaro.org> <20251007-rb1_hdmi_audio-v2-3-821b6a705e4c@linaro.org> <56vmqgrjy3je7omzirxnfxtuocebbj356iaew5thgkagi35464@hh34y7efssow> In-Reply-To: <56vmqgrjy3je7omzirxnfxtuocebbj356iaew5thgkagi35464@hh34y7efssow> On Tue Oct 21, 2025 at 2:03 PM BST, Dmitry Baryshkov wrote: > On Tue, Oct 21, 2025 at 01:56:09PM +0100, Alexey Klimov wrote: >> On Fri Oct 17, 2025 at 11:42 PM BST, Bjorn Andersson wrote: >> > On Fri, Oct 10, 2025 at 01:29:38PM +0100, Alexey Klimov wrote: >> >> On Tue Oct 7, 2025 at 1:39 PM BST, Konrad Dybcio wrote: >> >> > On 10/7/25 4:03 AM, Alexey Klimov wrote: >> >> >> Add the Low Power Audio SubSystem Low Power Island (LPASS LPI) pin >> >> >> controller device node required for audio subsystem on Qualcomm >> >> >> QRB2210 RB1. QRB2210 is based on qcm2290 which is based on sm6115. >> >> >>=20 >> >> >> While at this, also add description of lpi_i2s2 pins (active state= ) >> >> >> required for audio playback via HDMI/I2S. >> >> >>=20 >> >> >> Cc: Srinivas Kandagatla >> >> >> Signed-off-by: Alexey Klimov >> >> >> --- >> >> > >> >> > [...] >> >> > >> >> >> + lpi_i2s2_active: lpi-i2s2-active-state { >> >> >> + data-pins { >> >> >> + pins =3D "gpio12"; >> >> >> + function =3D "i2s2_data"; >> >> >> + bias-disable; >> >> >> + drive-strength =3D <8>; >> >> >> + output-high; >> >> > >> >> > I.. doubt output-high is what you want? >> >>=20 >> >> Why? Or is it because of some in-kernel gpiod? >> >>=20 >> > >> > What does "output-high" mean for a non-gpio function? >>=20 >> This is not efficient. It will be more useful to go straight to >> the point. > > It is efficient. It makes everybody think about it (and ask the same > question in future) instead of just depending on maintainers words. No. Imagine instead of this email you've got smth like this: "I.. doubt efficient is what you want?" >> This description of pins was taken from Qualcomm downstream code >> and the similar patch was applied (see provided URL in the prev email). > > And we all know that downstream can be buggy, incomplete, etc. > >> Back to your question -- does it matter here if it is gpio or non-gpio >> function? > > It does. The I2S data pin is supposed to be toggled in some way by a > certain IP core. What would it mean if we program output-high? Will the > pin still be toggled (by the function) or stay pulled up (because of the > output being programmed)? Here the topic was switched/replaced. And the other referenced email suggests that they don't want to see output property regardless. Anyway, as it was indicated in my previous email the problem they were trying to refer to was kinda understood. Thanks, Alexey