Re: [RFC][PATCH 1/2] ASoC: ti: ams-delta: Stop (ab)using card->pop_time

[Janusz Krzysztofik <jmkrzyszt@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Hi Mark,

On Wednesday, 22 April 2026 14:31:28 CEST Mark Brown wrote:
> On Wed, Apr 22, 2026 at 02:55:54AM +0000, Kuninori Morimoto wrote:
> 
> > @@ -280,14 +280,14 @@ static int cx81801_open(struct tty_struct *tty)
> >  {
> >  	int ret;
> >  
> > -	if (!cx20442_codec)
> > +	if (!cx20442_codec.component)
> >  		return -ENODEV;
> >  
> >  	/*
> >  	 * Pass the codec structure pointer for use by other ldisc callbacks,
> >  	 * both the card and the codec specific parts.
> >  	 */
> > -	tty->disc_data = cx20442_codec;
> > +	tty->disc_data = &cx20442_codec;
> >  
> >  	ret = v253_ops.open(tty);
> >  
> 
> We need an update in _close() as well, that's getting the component from
> disc_data.

Thanks for spotting this.  We should now get the component from 
cx20442_codec.component in _close(), as we do in _receive(), and return if 
(tty->disc_data != &cx20442_codec), maybe also WARN_ON(), or even BUG_ON().  
Sorry for missing that.

Kuninori, will you take care yourself, or do you prefer me to send a fixed 
version?

Thanks,
Janusz

> 


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]