From: Vinod Koul <vkoul@kernel.org>
To: "Liao, Bard" <bard.liao@intel.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Arnd Bergmann <arnd@arndb.de>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
"sound-open-firmware@alsa-project.org"
<sound-open-firmware@alsa-project.org>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT
Date: Mon, 31 Mar 2025 12:28:23 +0530 [thread overview]
Message-ID: <Z+o9D7FhTyUp2Y9o@vaman> (raw)
In-Reply-To: <SJ2PR11MB8424B5677C548803F2F2A513FFA02@SJ2PR11MB8424.namprd11.prod.outlook.com>
On 28-03-25, 14:15, Liao, Bard wrote:
>
>
> > -----Original Message-----
> > From: Arnd Bergmann <arnd@kernel.org>
> > Sent: Friday, March 28, 2025 9:25 PM
> > To: Liam Girdwood <lgirdwood@gmail.com>; Peter Ujfalusi
> > <peter.ujfalusi@linux.intel.com>; Bard Liao <yung-chuan.liao@linux.intel.com>;
> > Ranjani Sridharan <ranjani.sridharan@linux.intel.com>; Daniel Baluta
> > <daniel.baluta@nxp.com>; Mark Brown <broonie@kernel.org>; Jaroslav Kysela
> > <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Vinod Koul
> > <vkoul@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>; Kai Vehmanen
> > <kai.vehmanen@linux.intel.com>; Pierre-Louis Bossart <pierre-
> > louis.bossart@linux.dev>; sound-open-firmware@alsa-project.org; linux-
> > sound@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
> > CONFIG_SND_SOF_SOF_HDA_SDW_BPT
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The newly added driver fails to link without this:
> >
> > ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> >
> > Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire
> > BPT DMA")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I have the same patch which is pending review/apply.
> https://patchwork.kernel.org/project/alsa-devel/patch/20250321023032.7420-2-yung-chuan.liao@linux.intel.com/
> I am fine if we go with this patch.
> Acked-by: Bard Liao <yung-chuan.liao@linux.intel.com>
I have picked yours as that came first, thanks
--
~Vinod
prev parent reply other threads:[~2025-03-31 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 13:24 [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select CONFIG_SND_SOF_SOF_HDA_SDW_BPT Arnd Bergmann
2025-03-28 14:15 ` Liao, Bard
2025-03-31 6:58 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+o9D7FhTyUp2Y9o@vaman \
--to=vkoul@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox