Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: srinivas.kandagatla@linaro.org
Cc: broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
	krzysztof.kozlowski@linaro.org, linux-sound@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmitry.baryshkov@linaro.org, johan+linaro@kernel.org
Subject: Re: [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes
Date: Tue, 4 Mar 2025 18:04:55 +0100	[thread overview]
Message-ID: <Z8cyt2n7qj4GkcJC@hovoldconsulting.com> (raw)
In-Reply-To: <20250304105723.10579-1-srinivas.kandagatla@linaro.org>

On Tue, Mar 04, 2025 at 10:57:17AM +0000, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> On Qualcomm Audioreach setup, some of the audio artifacts are seen in
> both recording and playback. These patches fix issues by
> 1. Adjusting the fragment size that dsp can service.
> 2. schedule available playback buffers in time for dsp to not hit under runs 
> 3. remove some of the manual calculations done to get hardware pointer.
> 
> With these patches, am able to see Audio quality improvements.
> 
> Any testing would be appreciated.

This fixes the playback and capture issues with Pipewire, including the
heavily distorted, choppy playback when pavucontrol is open. Turns out
that the pavucontrol volume meters reduces the output sink quantum size
from the default 1024 to 256, which was too low with v2 but now seems to
work.

Unfortunately, this series still regresses Pulseaudio as capture is now
choppy (e.g. when recording using parecord).

During our off-list debugging sessions you suggested reducing the max
capture period size (that this series increases) to 6144 (same as min)
and that fixed the Pulseaudio capture issue. In v3 the, the max period
is again increased to 65536 which appears to break Pulseaudio capture.

> Changes since v2:
> 	- dropped patch which is causing regression with pluseaudio.
> 	- setup period sizes only for capture path
> 	- fix underruns/overruns in dsp pipelines.
> 	- add fixes tag
> 	- add patch to fix buffer alignment

Johan

  parent reply	other threads:[~2025-03-04 17:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 10:57 [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes srinivas.kandagatla
2025-03-04 10:57 ` [PATCH v3 1/6] ASoC: q6apm-dai: schedule all available frames to avoid dsp under-runs srinivas.kandagatla
2025-03-04 10:57 ` [PATCH v3 2/6] ASoC: q6apm: add q6apm_get_hw_pointer helper srinivas.kandagatla
2025-03-04 10:57 ` [PATCH v3 3/6] ASoC: q6apm-dai: make use of q6apm_get_hw_pointer srinivas.kandagatla
2025-03-04 10:57 ` [PATCH v3 4/6] ASoC: qdsp6: q6apm-dai: set correct period and buffer alignment srinivas.kandagatla
2025-03-04 10:57 ` [PATCH v3 5/6] ASoC: qdsp6: q6apm-dai: fix capture pipeline overruns srinivas.kandagatla
2025-03-04 10:57 ` [PATCH v3 6/6] ASoC: qdsp6: q6apm-dai: fix playback dsp pipeline underruns srinivas.kandagatla
2025-03-04 17:04 ` Johan Hovold [this message]
2025-03-04 17:12   ` [PATCH v3 0/6] ASoC: q6apm: fix under runs and fragment sizes Srinivas Kandagatla
2025-03-04 17:19     ` Johan Hovold
2025-03-05  9:06       ` Johan Hovold
2025-03-05  9:21         ` Johan Hovold
2025-03-05 22:17 ` Caleb Connolly
2025-03-06 13:15   ` Srinivas Kandagatla
2025-03-06 17:04     ` Dmitry Baryshkov
2025-03-06 13:56 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8cyt2n7qj4GkcJC@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox