From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, conor+dt@kernel.org,
krzysztof.kozlowski@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v1] ASoC: tas2562: remove tas2563 into driver
Date: Wed, 13 Dec 2023 15:45:05 +0200 [thread overview]
Message-ID: <ZXm1YcSOND-LjpLn@smile.fi.intel.com> (raw)
In-Reply-To: <20231212050831.982-1-shenghao-ding@ti.com>
On Tue, Dec 12, 2023 at 01:08:31PM +0800, Shenghao Ding wrote:
> Remove tas2563 from tas2562, it will be supported in separated driver code.
No objection from the code perspective. The Q is, what is the behaviour of the
current users? Imagine we have a used of this chip and this driver gets it
enumerated. Does it work? if so, this patch can not be applied right now.
Otherwise the commit message above is missing an elaboration of the case.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-12-13 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 5:08 [PATCH v1] ASoC: tas2562: remove tas2563 into driver Shenghao Ding
2023-12-12 8:22 ` Krzysztof Kozlowski
2023-12-12 8:25 ` [EXTERNAL] " Ding, Shenghao
2023-12-12 13:29 ` Mark Brown
2023-12-13 13:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXm1YcSOND-LjpLn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox