From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Gergo Koteles <soyer@irl.hu>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ALSA: hda/tas2781: add debug statements to kcontrols
Date: Tue, 26 Mar 2024 00:07:01 +0200 [thread overview]
Message-ID: <ZgH1hVH_1-7kFbgp@surfacebook.localdomain> (raw)
In-Reply-To: <377e0f33-697c-4baf-ac48-baff6199dd53@linux.intel.com>
Mon, Mar 25, 2024 at 05:01:18PM -0500, Pierre-Louis Bossart kirjoitti:
...
> > + dev_dbg(tas_priv->dev, "%s: %d\n", __func__,
>
> Nit-pick: you don't need to add __func__ to dev_dbg logs, the user can
> add the information with the dyndbg parameter, e.g.
>
> options snd_intel_dspcfg dyndbg=+pmf
>
> dev_err/warn don't have this functionality though so in those cases
> there's no replacement for __func__
You beat me up to it, I just downloaded the email thread to say the same.
Since I'm here, I think __func__ in dev_err()/dev_warn() usually says about
poorly written message itself (that it's not unique enough to distinguish
taking into account that this has device instance name as well). While pr_*()
ones indeed may benefit from having it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-03-25 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 21:25 [PATCH 0/3] ALSA: hda/tas2781: fixes for 6.9-rc1 Gergo Koteles
2024-03-25 21:25 ` [PATCH 1/3] ALSA: hda/tas2781: remove digital gain kcontrol Gergo Koteles
2024-03-26 12:58 ` kernel test robot
2024-03-27 4:21 ` kernel test robot
2024-03-25 21:25 ` [PATCH 2/3] ALSA: hda/tas2781: add locks to kcontrols Gergo Koteles
2024-03-25 21:25 ` [PATCH 3/3] ALSA: hda/tas2781: add debug statements " Gergo Koteles
2024-03-25 22:01 ` Pierre-Louis Bossart
2024-03-25 22:07 ` Andy Shevchenko [this message]
2024-03-25 23:13 ` Gergo Koteles
2024-03-26 7:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgH1hVH_1-7kFbgp@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=kevin-lu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox