From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
kernel@pengutronix.de, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] ASoC: codecs: Drop explicit initialization of struct i2c_device_id::driver_data to 0
Date: Thu, 2 May 2024 13:14:18 +0300 [thread overview]
Message-ID: <ZjNnekOAhhjGh-Ph@smile.fi.intel.com> (raw)
In-Reply-To: <6uj2suuiu7tpomecii65f5lxuwgkhxnqs3lrpa54s2ptsorkh3@lzmnapdw4cri>
On Thu, May 02, 2024 at 11:25:13AM +0200, Uwe Kleine-König wrote:
> Hello Andy,
>
> On Thu, May 02, 2024 at 12:02:50PM +0300, Andy Shevchenko wrote:
> > On Thu, May 2, 2024 at 10:47 AM Uwe Kleine-König
> > <u.kleine-koenig@pengutronix.de> wrote:
> > >
> > > These drivers don't use the driver_data member of struct i2c_device_id,
> > > so don't explicitly initialize this member.
> > >
> > > This prepares putting driver_data in an anonymous union which requires
> > > either no initialization or named designators. But it's also a nice
> > > cleanup on its own.
> >
> > There are some drivers that have other (than I²C) ID tables, which
> > follow the same format. Can you also do the same with them for the
> > sake of consistency?
>
> I'm aware of these and plan to address them in a separate quest once I'm
> done with the i2c bits.
With this being promised, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-02 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 7:47 [PATCH] ASoC: codecs: Drop explicit initialization of struct i2c_device_id::driver_data to 0 Uwe Kleine-König
2024-05-02 9:02 ` Andy Shevchenko
2024-05-02 9:25 ` Uwe Kleine-König
2024-05-02 10:14 ` Andy Shevchenko [this message]
2024-05-05 15:03 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2024-06-24 13:17 Uwe Kleine-König
2024-06-25 18:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjNnekOAhhjGh-Ph@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox