From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-sound@vger.kernel.org, Paul Menzel <pmenzel@molgen.mpg.de>,
Jaroslav Kysela <perex@perex.cz>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 4/5] kselftest/alsa: mixer-test: Skip write tests for volatile controls
Date: Fri, 14 Jun 2024 15:29:03 +0100 [thread overview]
Message-ID: <ZmxTrzZK2lwSLRpl@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20240614124728.27901-5-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 812 bytes --]
On Fri, Jun 14, 2024 at 02:47:26PM +0200, Takashi Iwai wrote:
> The control elements with volatile flag don't guarantee that the
> written values are actually saved for the next reads, hence they
> aren't suitable for the standard mixer tests. Skip the write tests
> for those volatile controls for avoiding confusion.
We should still verify that you can actually write I think...
> + if (!snd_ctl_elem_info_is_volatile(ctl->info)) {
> + ksft_print_msg("%s is volatile\n", ctl->name);
> + ksft_test_result_skip("write_invalid.%d.%d\n",
> + ctl->card->card, ctl->elem);
> + return;
> + }
...and that you don't read back invalid values after a write like this
for example. I think any change for this should be in the validation of
the read but we should still try the writes we think we can do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-06-14 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 12:47 [PATCH 0/5] ALSA: some driver fixes for control input validations Takashi Iwai
2024-06-14 12:47 ` [PATCH 1/5] ALSA: vmaster: Return error for invalid input values Takashi Iwai
2024-06-14 12:47 ` [PATCH 2/5] ALSA: hda: Return -EINVAL for invalid volume/switch inputs Takashi Iwai
2024-06-14 12:47 ` [PATCH 3/5] ALSA: control: Apply sanity check of input values for user elements Takashi Iwai
2024-06-14 13:06 ` Jaroslav Kysela
2024-06-14 14:25 ` Mark Brown
2024-06-14 12:47 ` [PATCH 4/5] kselftest/alsa: mixer-test: Skip write tests for volatile controls Takashi Iwai
2024-06-14 14:29 ` Mark Brown [this message]
2024-06-14 14:40 ` Takashi Iwai
2024-06-14 12:47 ` [PATCH 5/5] ALSA: chmap: Mark Channel Map controls as volatile Takashi Iwai
2024-06-14 13:06 ` [PATCH 0/5] ALSA: some driver fixes for control input validations Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmxTrzZK2lwSLRpl@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pmenzel@molgen.mpg.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox