From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-sound@vger.kernel.org, Paul Menzel <pmenzel@molgen.mpg.de>,
Jaroslav Kysela <perex@perex.cz>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls
Date: Fri, 14 Jun 2024 17:28:01 +0100 [thread overview]
Message-ID: <ZmxvkbDfmhRbBjeB@finisterre.sirena.org.uk> (raw)
In-Reply-To: <878qz77bir.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
On Fri, Jun 14, 2024 at 06:08:12PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> +++ b/tools/testing/selftests/alsa/mixer-test.c
> @@ -668,6 +668,10 @@ static int write_and_verify(struct ctl_data *ctl,
> ksft_print_msg("%s read and written values differ\n",
> ctl->name);
>
> + /* Allow difference for volatile controls */
> + if (snd_ctl_elem_info_is_volatile(ctl->info))
> + return 0;
> +
> return -1;
> }
That'll still print the warnings about the values differing and won't
check the values are in range... I'll send a patch.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-06-14 16:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 15:37 [PATCH v2 0/6] ALSA: some driver fixes for control input validations Takashi Iwai
2024-06-14 15:37 ` [PATCH v2 1/6] ALSA: vmaster: Return error for invalid input values Takashi Iwai
2024-06-14 15:37 ` [PATCH v2 2/6] ALSA: hda: Return -EINVAL for invalid volume/switch inputs Takashi Iwai
2024-06-14 15:37 ` [PATCH v2 3/6] ALSA: control: Apply sanity check of input values for user elements Takashi Iwai
2024-06-15 5:13 ` Takashi Sakamoto
2024-06-15 7:28 ` Takashi Iwai
2024-06-15 8:02 ` Takashi Sakamoto
2024-06-15 8:30 ` Takashi Iwai
2024-06-15 11:37 ` Takashi Iwai
2024-06-16 3:39 ` Takashi Sakamoto
2024-06-14 15:37 ` [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls Takashi Iwai
2024-06-14 15:43 ` Jaroslav Kysela
2024-06-14 15:57 ` Mark Brown
2024-06-14 16:08 ` Takashi Iwai
2024-06-14 16:28 ` Mark Brown [this message]
2024-06-14 15:37 ` [PATCH v2 5/6] ALSA: chmap: Mark Channel Map controls as volatile Takashi Iwai
2024-06-14 15:37 ` [PATCH v2 6/6] ALSA: hda: Add input value sanity checks to HDMI channel map controls Takashi Iwai
2024-06-14 15:44 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmxvkbDfmhRbBjeB@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pmenzel@molgen.mpg.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox