From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: <perex@perex.cz>, <tiwai@suse.com>, <lgirdwood@gmail.com>,
<linux-sound@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v3 3/4] ASoC: cs35l45: Use new snd_soc_component_get_kcontrol() helper
Date: Fri, 2 Aug 2024 09:44:59 +0100 [thread overview]
Message-ID: <Zqyci3/+iGreUZPP@opensource.cirrus.com> (raw)
In-Reply-To: <c4712e65-2914-4fa5-900c-e85edb7246d8@sirena.org.uk>
On Thu, Aug 01, 2024 at 05:38:32PM +0100, Mark Brown wrote:
> On Thu, Aug 01, 2024 at 11:04:12AM +0100, Charles Keepax wrote:
> > No longer any need to hard code the addition of the name prefix, use the
> > new helper.
>
> > - kcontrol = snd_soc_card_get_kcontrol_locked(component->card, name);
> > + kcontrol = snd_soc_component_get_kcontrol_locked(component->card, ctl_name);
>
> That's not the helper that the subject line references, nor the one
> added by the prior patch - did you test this?
>
> Please use cover letters for patch serieses too.
Well I thought I did but clearly not, apologies will check it and
send a new spin.
Thanks,
Charles
next prev parent reply other threads:[~2024-08-02 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 10:04 [PATCH v3 1/4] ASoC: cs42l43: Remove redundant semi-colon at end of function Charles Keepax
2024-08-01 10:04 ` [PATCH v3 2/4] ASoC: soc-component: Add new snd_soc_component_get_kcontrol() helper Charles Keepax
2024-08-01 10:04 ` [PATCH v3 3/4] ASoC: cs35l45: Use " Charles Keepax
2024-08-01 16:38 ` Mark Brown
2024-08-02 8:44 ` Charles Keepax [this message]
2024-08-01 10:04 ` [PATCH v3 4/4] ASoC: cs42l43: Cache shutter IRQ control pointers Charles Keepax
2024-08-02 22:28 ` [PATCH v3 1/4] ASoC: cs42l43: Remove redundant semi-colon at end of function Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zqyci3/+iGreUZPP@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox