From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, ckeepax@opensource.cirrus.com, heiko@sntech.de,
robh@kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com
Subject: Re: [PATCH] ASoC: ak4458: remove "reset-gpios" property handler
Date: Fri, 9 Aug 2024 18:36:01 +0300 [thread overview]
Message-ID: <ZrY3YZrvsua5DErC@smile.fi.intel.com> (raw)
In-Reply-To: <1720009575-11677-1-git-send-email-shengjiu.wang@nxp.com>
On Wed, Jul 03, 2024 at 08:26:15PM +0800, Shengjiu Wang wrote:
> commit c721f189e89c0 ("reset: Instantiate reset GPIO controller for
> shared reset-gpios") check if there is no "resets" property
> will fallback to "reset-gpios".
>
> So don't need to handle "reset-gpios" separately in the driver,
> the "reset-gpios" handler is duplicated with "resets" control handler,
> remove it.
...
> - if (ak4458->reset_gpiod) {
> - gpiod_set_value_cansleep(ak4458->reset_gpiod, active);
> - usleep_range(1000, 2000);
> - } else if (!IS_ERR_OR_NULL(ak4458->reset)) {
> + if (!IS_ERR_OR_NULL(ak4458->reset)) {
_OR_NULL is redundant.
> if (active)
> reset_control_assert(ak4458->reset);
> else
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-08-09 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 12:26 [PATCH] ASoC: ak4458: remove "reset-gpios" property handler Shengjiu Wang
2024-07-04 15:01 ` Mark Brown
2024-08-09 15:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrY3YZrvsua5DErC@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox