From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH] soundwire: add lane field in sdw_port_runtime
Date: Sun, 18 Aug 2024 12:51:05 +0530 [thread overview]
Message-ID: <ZsGg4c7Nc0jiyGgK@vaman> (raw)
In-Reply-To: <20240806060930.10433-1-yung-chuan.liao@linux.intel.com>
On 06-08-24, 14:09, Bard Liao wrote:
> Currently, lane_ctrl is always 0. Add a lane field in sdw_port_runtime
> to indicate the data lane of the data port.
> They are 0 by default.
Use of the lane? also missing setting of lane variable, dont see in this
patch so we are passing garbage? It might work as structure is kzalloced
but I dont think we should be implicit, programming makes sense
>
> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> ---
> drivers/soundwire/amd_manager.c | 2 +-
> drivers/soundwire/bus.h | 2 ++
> drivers/soundwire/generic_bandwidth_allocation.c | 4 ++--
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> index 0d01849c3586..babb580f3124 100644
> --- a/drivers/soundwire/amd_manager.c
> +++ b/drivers/soundwire/amd_manager.c
> @@ -410,7 +410,7 @@ static int amd_sdw_compute_params(struct sdw_bus *bus)
> sdw_fill_xport_params(&p_rt->transport_params, p_rt->num,
> false, SDW_BLK_GRP_CNT_1, sample_int,
> port_bo, port_bo >> 8, hstart, hstop,
> - SDW_BLK_PKG_PER_PORT, 0x0);
> + SDW_BLK_PKG_PER_PORT, p_rt->lane);
>
> sdw_fill_port_params(&p_rt->port_params,
> p_rt->num, bps,
> diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h
> index fda6b24ac2da..ff03b97f1d8b 100644
> --- a/drivers/soundwire/bus.h
> +++ b/drivers/soundwire/bus.h
> @@ -90,6 +90,7 @@ int sdw_find_col_index(int col);
> * @transport_params: Transport parameters
> * @port_params: Port parameters
> * @port_node: List node for Master or Slave port_list
> + * @lane: Which lane is used
> *
> * SoundWire spec has no mention of ports for Master interface but the
> * concept is logically extended.
> @@ -100,6 +101,7 @@ struct sdw_port_runtime {
> struct sdw_transport_params transport_params;
> struct sdw_port_params port_params;
> struct list_head port_node;
> + unsigned int lane;
> };
>
> /**
> diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
> index b9316207c3ab..abf9b85daa52 100644
> --- a/drivers/soundwire/generic_bandwidth_allocation.c
> +++ b/drivers/soundwire/generic_bandwidth_allocation.c
> @@ -56,7 +56,7 @@ void sdw_compute_slave_ports(struct sdw_master_runtime *m_rt,
> sample_int, port_bo, port_bo >> 8,
> t_data->hstart,
> t_data->hstop,
> - SDW_BLK_PKG_PER_PORT, 0x0);
> + SDW_BLK_PKG_PER_PORT, p_rt->lane);
>
> sdw_fill_port_params(&p_rt->port_params,
> p_rt->num, bps,
> @@ -109,7 +109,7 @@ static void sdw_compute_master_ports(struct sdw_master_runtime *m_rt,
> sdw_fill_xport_params(&p_rt->transport_params, p_rt->num,
> false, SDW_BLK_GRP_CNT_1, sample_int,
> *port_bo, (*port_bo) >> 8, hstart, hstop,
> - SDW_BLK_PKG_PER_PORT, 0x0);
> + SDW_BLK_PKG_PER_PORT, p_rt->lane);
>
> sdw_fill_port_params(&p_rt->port_params,
> p_rt->num, bps,
> --
> 2.43.0
--
~Vinod
next prev parent reply other threads:[~2024-08-18 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 6:09 [PATCH] soundwire: add lane field in sdw_port_runtime Bard Liao
2024-08-18 7:21 ` Vinod Koul [this message]
2024-08-19 3:27 ` Liao, Bard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsGg4c7Nc0jiyGgK@vaman \
--to=vkoul@kernel.org \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox