From: Mark Brown <broonie@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev,
Neil Armstrong <neil.armstrong@linaro.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Weidong Wang <wangweidong.a@awinic.com>,
Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
Herve Codina <herve.codina@bootlin.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Shuming Fan <shumingf@realtek.com>
Subject: Re: [PATCH v2 7/9] ASoC: loongson: Add I2S controller driver as platform device
Date: Tue, 24 Sep 2024 11:14:45 +0200 [thread overview]
Message-ID: <ZvKDBc2Kohx9kPfQ@finisterre.sirena.org.uk> (raw)
In-Reply-To: <fd3989d15546502b47f580e6a2c3a59cb628ce93.1727056789.git.zhoubinbin@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Tue, Sep 24, 2024 at 03:00:48PM +0800, Binbin Zhou wrote:
> config SND_SOC_LOONGSON_I2S_PCI
> tristate "Loongson I2S-PCI Device Driver"
> - select REGMAP_MMIO
> depends on PCI
> + select REGMAP_MMIO
> + select SND_SOC_LOONGSON_CARD
> help
> Say Y or M if you want to add support for I2S driver for
> Loongson I2S controller.
You shouldn't select the card from the DAI drivers, some system might
use the driver with a different card for some reason. If anything a
select from the card to the DAI driver is more appropriate, cards are
the main user thing.
> +++ b/sound/soc/loongson/loongson_i2s_plat.c
> @@ -0,0 +1,186 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Loongson I2S controller master mode dirver(platform device)
Please use C++ style for the whole comment block so things look more
intentional.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-09-24 9:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 6:59 [PATCH v2 0/9] ASoC: Some issues about loongson i2s Binbin Zhou
2024-09-24 6:59 ` [PATCH v2 1/9] ASoC: dt-bindings: Add Everest ES8323 Codec Binbin Zhou
2024-09-24 23:26 ` Rob Herring (Arm)
2024-09-24 7:00 ` [PATCH v2 2/9] ASoC: codecs: Add support for ES8323 Binbin Zhou
2024-09-24 9:03 ` Mark Brown
2024-09-25 8:44 ` Binbin Zhou
2024-09-24 7:00 ` [PATCH v2 3/9] ASoC: dt-bindings: Add NXP uda1342 Codec Binbin Zhou
2024-09-24 7:00 ` [PATCH v2 4/9] ASoC: codecs: Add uda1342 codec driver Binbin Zhou
2024-09-24 9:09 ` Mark Brown
2024-09-24 15:58 ` kernel test robot
2024-09-24 17:31 ` kernel test robot
2024-09-24 7:00 ` [PATCH v2 5/9] ASoC: loongson: Fix codec detection failure on FDT systems Binbin Zhou
2024-09-24 9:19 ` Mark Brown
2024-09-25 9:05 ` Binbin Zhou
2024-09-24 7:00 ` [PATCH v2 6/9] ASoC: dt-bindings: Add Loongson I2S controller Binbin Zhou
2024-09-24 23:27 ` Rob Herring (Arm)
2024-09-24 7:00 ` [PATCH v2 7/9] ASoC: loongson: Add I2S controller driver as platform device Binbin Zhou
2024-09-24 9:14 ` Mark Brown [this message]
2024-09-26 2:03 ` Binbin Zhou
2024-09-26 7:45 ` Mark Brown
2024-09-27 1:27 ` Binbin Zhou
2024-09-24 21:26 ` kernel test robot
2024-09-25 4:18 ` kernel test robot
2024-09-24 7:01 ` [PATCH v2 8/9] LoongArch: dts: Add I2S support to Loongson-2K1000 Binbin Zhou
2024-09-24 7:01 ` [PATCH v2 9/9] LoongArch: dts: Add I2S support to Loongson-2K2000 Binbin Zhou
2024-09-24 11:36 ` [PATCH v2 0/9] ASoC: Some issues about loongson i2s Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvKDBc2Kohx9kPfQ@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=luca.ceresoli@bootlin.com \
--cc=masahiroy@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=quic_pkumpatl@quicinc.com \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=wangweidong.a@awinic.com \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox