From: Mark Brown <broonie@kernel.org>
To: Igor Prusov <ivprusov@salutedevices.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@salutedevices.com,
prusovigor@gmail.com
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E
Date: Tue, 24 Sep 2024 14:31:40 +0200 [thread overview]
Message-ID: <ZvKxLPQ1fcF8JBU4@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20240920-es7243e-adc-v2-1-0be019735b81@salutedevices.com>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On Fri, Sep 20, 2024 at 06:41:07PM +0300, Igor Prusov wrote:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + items:
> + - const: sclk
> + - const: lrclk
This is quite weird and doesn't seem to correspond to the chip datasheet
at:
http://www.everest-semi.com/pdf/ES7243%20PB.pdf
https://www.pawpaw.cn/media/documents/2022-04/ES7243E_DS_pawpaw%E6%9C%A8%E7%93%9C%E7%A7%91%E6%8A%80.pdf
The SCLK and LRCLK appear to be the bit and frame sync clocks which
would not normally be exposed directly via the clock API (so this is
probably not going to be joined up with whatever SoC it's connected to).
On the other hand there *is* a MCLK which would much more normally be
represented in the DT bindings and isn't represented here or managed by
the driver.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-09-24 12:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 15:41 [PATCH v2 0/2] Add ES7243E ADC driver Igor Prusov
2024-09-20 15:41 ` [PATCH v2 1/2] ASoC: dt-bindings: Add Everest ES7243E Igor Prusov
2024-09-24 12:31 ` Mark Brown [this message]
2024-09-20 15:41 ` [PATCH v2 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov
2024-09-21 12:59 ` kernel test robot
2024-09-21 17:38 ` kernel test robot
2024-09-21 21:34 ` kernel test robot
2024-09-24 12:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvKxLPQ1fcF8JBU4@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivprusov@salutedevices.com \
--cc=kernel@salutedevices.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=prusovigor@gmail.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox