From: Mark Brown <broonie@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Alexey Klimov <alexey.klimov@linaro.org>,
srinivas.kandagatla@linaro.org, a39.skl@gmail.com,
linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
krzysztof.kozlowski@linaro.org, vkoul@kernel.org,
klimov.linux@gmail.com
Subject: Re: [PATCH REVIEW 1/2] ASoC: codecs: lpass-rx-macro: fix RXn(rx,n) macro for DSM_CTL and SEC7 regs
Date: Wed, 25 Sep 2024 10:53:57 +0200 [thread overview]
Message-ID: <ZvPPpfobvDmmTCfi@finisterre.sirena.org.uk> (raw)
In-Reply-To: <czlx4thp7thnb6jrauilpbtzgbq637rmnwlpifxq5b5jfa3lqm@toyy3b2viscr>
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
On Wed, Sep 25, 2024 at 11:27:54AM +0300, Dmitry Baryshkov wrote:
> On Wed, Sep 25, 2024 at 05:38:22AM GMT, Alexey Klimov wrote:
> > +#define CDC_RX_RXn_RX_PATH_SEC7(rx, n) \
> > + (0x0434 + rx->rxn_reg_stride * n + n * (n - 1) * rx->rxn_reg_stride2)
> This is a nice hack to rule out n=0 and n=1, but maybe we can be more
> obvious here:
> (0x0434 + stride * n + (n > 2) ? stride2 : 0)
Yes. We could also use some brackets to make the + and * precedence
obvious.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-09-25 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 4:38 [PATCH REVIEW 1/2] ASoC: codecs: lpass-rx-macro: fix RXn(rx,n) macro for DSM_CTL and SEC7 regs Alexey Klimov
2024-09-25 4:38 ` [PATCH REVIEW 2/2] ASoC: codecs: lpass-rx-macro: add missing CDC_RX_BCL_VBAT_RF_PROC2 to default regs values Alexey Klimov
2024-09-25 8:27 ` [PATCH REVIEW 1/2] ASoC: codecs: lpass-rx-macro: fix RXn(rx,n) macro for DSM_CTL and SEC7 regs Dmitry Baryshkov
2024-09-25 8:53 ` Mark Brown [this message]
2024-09-25 12:41 ` Alexey Klimov
2024-09-25 15:09 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvPPpfobvDmmTCfi@finisterre.sirena.org.uk \
--to=broonie@kernel.org \
--cc=a39.skl@gmail.com \
--cc=alexey.klimov@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=klimov.linux@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox