From: Krzysztof Kozlowski <krzk@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Srinivas Kandagatla <srini@kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 3/4] ASoC: codecs: wsa884x: fix codec initialisation
Date: Fri, 2 Jan 2026 13:26:01 +0100 [thread overview]
Message-ID: <a11d661e-15a0-4d9b-a171-6bc1d31a16d9@kernel.org> (raw)
In-Reply-To: <aVe3VgrKi7WsqrYA@hovoldconsulting.com>
On 02/01/2026 13:17, Johan Hovold wrote:
>>> ...
>>>
>>> wsa884x_init(wsa884x);
>>>
>>> so if you set hw_init to true then init is never called when status is
>>> changed to ATTACHED.
>>
>> Uh, indeed, so this was supposed to be !wsa884x->hw_init... or indeed
>> your meaning. This also means that this was never passing above if() and
>> the init() was never called.
>>
>> regcache was probably synced via runtime PM, so at least that part worked.
>>
>> Did you test this driver on actual device how it affects the behavior?
>
> No, I don't have a device that uses this codec anymore.
>
> If you could give it a spin that would be great. It seems we have been
> depending on reset values or an UNATTACHED => ATTACHED transition so
> far.
I can test it, maybe after the weekend.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-02 12:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 11:14 [PATCH 0/4] ASoC: codecs: wsa88xx: fix codec initialisation Johan Hovold
2026-01-02 11:14 ` [PATCH 1/4] ASoC: codecs: wsa883x: fix unnecessary initialisation Johan Hovold
2026-01-05 9:31 ` Krzysztof Kozlowski
2026-01-02 11:14 ` [PATCH 2/4] ASoC: codecs: wsa881x: " Johan Hovold
2026-01-05 9:32 ` Krzysztof Kozlowski
2026-01-02 11:14 ` [PATCH 3/4] ASoC: codecs: wsa884x: fix codec initialisation Johan Hovold
2026-01-02 11:31 ` Krzysztof Kozlowski
2026-01-02 11:43 ` Johan Hovold
2026-01-02 11:50 ` Krzysztof Kozlowski
2026-01-02 12:17 ` Johan Hovold
2026-01-02 12:26 ` Krzysztof Kozlowski [this message]
2026-01-05 9:30 ` Krzysztof Kozlowski
2026-01-02 11:14 ` [PATCH 4/4] ASoC: codecs: wsa883x: suppress variant printk Johan Hovold
2026-01-05 9:32 ` Krzysztof Kozlowski
2026-01-05 11:50 ` [PATCH 0/4] ASoC: codecs: wsa88xx: fix codec initialisation Srinivas Kandagatla
2026-01-06 18:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a11d661e-15a0-4d9b-a171-6bc1d31a16d9@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=srini@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox