Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Hans Peter <flurry123@gmx.ch>
To: tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 840 G8 (MB 8AB8)
Date: Sun, 18 Feb 2024 13:16:03 +0100	[thread overview]
Message-ID: <a170992c-2acf-42f9-9dcc-b5dae5fffa67@gmx.ch> (raw)

The HP EliteBook 840 G8 seems to be circulating with different
subsystem-IDs. alsa-info.sh showed on my box:

!!DMI Information
!!---------------

Manufacturer:      HP
Product Name:      HP EliteBook 840 G8 Notebook PC
Product Version:   SBKPF
Firmware Version:  T37 Ver. 01.15.02
System SKU:        5S7R6EC#ABD
Board Vendor:      HP
Board Name:        8AB8

...

!!HDA-Intel Codec information
!!---------------------------
--startcollapse--

Codec: Realtek ALC285
Address: 0
AFG Function Id: 0x1 (unsol 1)
Vendor Id: 0x10ec0285
Subsystem Id: 0x103c8ab9
Revision Id: 0x100002


So an additional quirk enabled mute led for me:

--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9752,6 +9752,7 @@
  	SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)",
ALC236_FIXUP_HP_GPIO_LED),
  	SND_PCI_QUIRK(0x103c, 0x8aa8, "HP EliteBook 640 G9 (MB 8AA6)",
ALC236_FIXUP_HP_GPIO_LED),
  	SND_PCI_QUIRK(0x103c, 0x8aab, "HP EliteBook 650 G9 (MB 8AA9)",
ALC236_FIXUP_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8ab9, "HP EliteBook 840 G8 (MB 8AB8)",
ALC285_FIXUP_HP_GPIO_LED),
  	SND_PCI_QUIRK(0x103c, 0x8abb, "HP ZBook Firefly 14 G9",
ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
  	SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook
PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
  	SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook
PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),


             reply	other threads:[~2024-02-18 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18 12:16 Hans Peter [this message]
2024-02-19  8:31 ` [PATCH] ALSA: hda/realtek: Enable Mute LED on HP 840 G8 (MB 8AB8) Takashi Iwai
2024-02-19 16:00   ` Hans Peter
2024-02-19 16:28     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a170992c-2acf-42f9-9dcc-b5dae5fffa67@gmx.ch \
    --to=flurry123@gmx.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox