From: "Wang, Sen" <sen@ti.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] ASoC: simple-card-utils: support system-clock-id DT property
Date: Thu, 14 May 2026 18:40:31 -0500 [thread overview]
Message-ID: <a430e7f5-232d-4c7d-83c9-c120fe682424@ti.com> (raw)
In-Reply-To: <87tss9wqhx.wl-kuninori.morimoto.gx@renesas.com>
On 5/14/2026 5:55 PM, Kuninori Morimoto wrote:
>
> Hi Sen
>
>> Looking for feedbacks & on this before I draft a proper series w/
>> dt-binding.
>>
>> The generic machine driver never had a mechanism to adjust for various
>> clk_ids that is tailored for individual codec & cpu peripherial driver.
>> simple_util_dai_init() has hardcoded 0, thus making non-default clock IDs
>> unreachable from DTS. Boards needing a specific clk_id have had no choice
>> but to write dedicated machine drivers.
>>
>> This adds an optional "system-clock-id" u32 property to the cpu/codec
>> sub-node. When absent clk_id stays 0, preserving identical behaviour
>> for all existing boards.
>>
>> Signed-off-by: Sen Wang <sen@ti.com>
>> ---
>
> Looks good for me (except DT bindings)
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Thank you for your help !!
Hi Morimoto-san,
Thank you for the review, will send out a V2 with dt-bindings.
Best,
Sen Wang
prev parent reply other threads:[~2026-05-14 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 21:28 [RFC PATCH] ASoC: simple-card-utils: support system-clock-id DT property Sen Wang
2026-05-14 22:55 ` Kuninori Morimoto
2026-05-14 23:40 ` Wang, Sen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a430e7f5-232d-4c7d-83c9-c120fe682424@ti.com \
--to=sen@ti.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox