From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vitaly Rodionov <vitalyr@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: add spi bus properties
Date: Wed, 22 Oct 2025 15:50:09 +0200 [thread overview]
Message-ID: <a567b0d6-f489-4d71-be52-b7d8e0179d51@kernel.org> (raw)
In-Reply-To: <882aa222-fe4f-4724-87eb-4480de91919d@kernel.org>
On 22/10/2025 15:42, Krzysztof Kozlowski wrote:
> On 22/10/2025 15:38, Vitaly Rodionov wrote:
>> This patch adds property for cs530x SPI control bus
>> with max frequency 24MHz.
>
> Why?
>
> You described what you did, we see that from the diff. Explain why you
> are doing this, e.g. hardware is like that? Old hardware? New hardware?
> Both? If only new, then why this is a separate patch?
>
> Also, since I expect new version:
> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
>
And after looking at next patch I understand why - you add SPI which was
not there, so this patch is not correct alone anyway. You need a ref to
spi-peripheral-props (see any other SPI device). My previous questions
still stay valid though - how this relates to existing devices and to
earlier patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-22 13:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 13:38 [PATCH v5 00/12] Add support for Cirrus Logic CS530x DAC and CODEC variants Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 01/12] ASoC: cs530x: Update the copyright headers Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 02/12] ASoC: cs530x: Sort #include directives and tydy up whitespaces Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 03/12] ASoC: cs530x: Remove unused struct members and constants Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 04/12] ASoC: cs530x: Correct constant naming Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 05/12] ASoC: dt-bindings: sound: cirrus: cs530x: Add cs530x Vitaly Rodionov
2025-10-22 13:41 ` Krzysztof Kozlowski
2025-10-22 13:38 ` [PATCH v5 06/12] ASoC: cs530x: Add CODEC and DAC support Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 07/12] ASoC: cs530x: Rename bitfield to reflect common use for ADC and DAC Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 08/12] ASoC: cs530x: Check the DEVID matches the devtype Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 09/12] ASoC: cs530x: Correct MCLK reference frequency values Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 10/12] ASoC: cs530x: Rename i2c related structures Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: add spi bus properties Vitaly Rodionov
2025-10-22 13:42 ` Krzysztof Kozlowski
2025-10-22 13:50 ` Krzysztof Kozlowski [this message]
2025-10-22 14:16 ` Vitaly Rodionov
2025-10-22 13:38 ` [PATCH v5 12/12] ASoC: cs530x: Add SPI bus support for cs530x parts Vitaly Rodionov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a567b0d6-f489-4d71-be52-b7d8e0179d51@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox