From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Banajit Goswami <bgoswami@quicinc.com>
Cc: neil.armstrong@linaro.org, linux-arm-msm@vger.kernel.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 3/3] ASoC: codec: lpass-rx-macro: add support for 2.5 codec version
Date: Thu, 13 Jun 2024 13:00:13 +0200 [thread overview]
Message-ID: <a6793126-ba1c-4679-a2c2-eabad4f5a506@linaro.org> (raw)
In-Reply-To: <20240612-lpass-codec-v25-v4-3-f63d3676dbc4@linaro.org>
On 13/06/2024 12:49, Srinivas Kandagatla wrote:
> LPASS Codec v2.5 has significant changes in the rx register strides.
> Due to this headset playback on SM8550, SM8650, x1e80100 and all SoCs
> after SM8450 have only Left working.
>
> This patch adjusts the registers to accomdate 2.5 changes. With this
> fixed now L and R are functional on Headset playback.
I was just about to respond, are you sure this is suitable for sm8450? I
looked now at registers and sm8450 (which should have codec v2.5) has
old style register layout.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I tested earlier version of patchset on SM8550 and X1E80100.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-13 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 10:49 [PATCH v4 0/3] ASoC: codecs: lpass: add support for v2.5 rx macro Srinivas Kandagatla
2024-06-13 10:49 ` [PATCH v4 1/3] ASoC: codecs: lpass-macro: add helpers to get codec version Srinivas Kandagatla
2024-06-13 10:49 ` [PATCH v4 2/3] ASoC: codec: lpass-rx-macro: prepare driver to accomdate new codec versions Srinivas Kandagatla
2024-06-13 10:49 ` [PATCH v4 3/3] ASoC: codec: lpass-rx-macro: add support for 2.5 codec version Srinivas Kandagatla
2024-06-13 11:00 ` Krzysztof Kozlowski [this message]
2024-06-13 11:04 ` Srinivas Kandagatla
2024-06-14 10:39 ` Krzysztof Kozlowski
2024-06-15 20:16 ` [PATCH v4 0/3] ASoC: codecs: lpass: add support for v2.5 rx macro Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6793126-ba1c-4679-a2c2-eabad4f5a506@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox