From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, venkataprasad.potturu@amd.com,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
Syed.SabaKareem@amd.com, Mario.Limonciello@amd.com
Subject: Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
Date: Fri, 7 Feb 2025 13:32:07 +0000 [thread overview]
Message-ID: <a799e6fa-5ef7-4e1b-993e-52555a73f2a8@sirena.org.uk> (raw)
In-Reply-To: <20250207062819.1527184-17-Vijendar.Mukunda@amd.com>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
On Fri, Feb 07, 2025 at 11:58:10AM +0530, Vijendar Mukunda wrote:
> + if (adata->acp_rev == ACP63_PCI_REV) {
> + } else {
Unless I find something major in the rest of the series I'll apply this
but it's much better to write these as case statements, that way if you
get additional types to handle it's easier to extend the code sensibly.
Please update this incrementally.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-02-07 13:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 6:27 [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms Vijendar Mukunda
2025-02-07 6:27 ` [PATCH V3 01/25] ASoC: amd: ps: rename structure names, variable and other macros Vijendar Mukunda
2025-02-07 6:27 ` [PATCH V3 02/25] ASoC: amd: ps: use macro for ACP6.3 pci revision id Vijendar Mukunda
2025-02-07 6:27 ` [PATCH V3 03/25] ASoC: amd: ps: add acp pci driver hw_ops for acp6.3 platform Vijendar Mukunda
2025-02-07 6:27 ` [PATCH V3 04/25] ASoC: amd: ps: add callback functions for acp pci driver pm ops Vijendar Mukunda
2025-02-07 6:27 ` [PATCH V3 05/25] ASoC: amd: ps: add callback to read acp pin configuration Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 06/25] ASoC: amd: ps: add soundwire dma irq thread callback Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 07/25] ASoC: amd: ps: refactor soundwire dma interrupt handling Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 08/25] ASoC: amd: ps: store acp revision id in SoundWire dma driver private data Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 09/25] ASoC: amd: ps: refactor soundwire dma driver code Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 10/25] ASoC: amd: ps: refactor soundwire dma interrupts enable/disable sequence Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 11/25] ASoC: amd: ps: rename acp_restore_sdw_dma_config() function Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 12/25] ASoC: amd: ps: add pci driver hw_ops for ACP7.0 & ACP7.1 variants Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 13/25] ASoC: amd: ps: add pm ops related hw_ops for ACP7.0 & ACP7.1 platforms Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 14/25] ASoC: amd: ps: add ACP7.0 & ACP7.1 specific soundwire dma driver changes Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 15/25] ASoC: amd: ps: implement function to restore dma config for ACP7.0 platform Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling " Vijendar Mukunda
2025-02-07 13:32 ` Mark Brown [this message]
2025-02-07 14:02 ` Mukunda,Vijendar
2025-02-07 6:28 ` [PATCH V3 17/25] ASoC: amd: ps: add soundwire wake interrupt handling Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 18/25] ASoC: amd: ps: update module description Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 19/25] ASoC: amd: ps: update file description and copyright year Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 20/25] ASoC: amd: update Pink Sardine platform Kconfig description Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 21/25] ASoC: amd: acp: add machine driver changes for ACP7.0 and ACP7.1 platforms Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 22/25] ASoC: amd: acp: add RT711, RT714 & RT1316 support for ACP7.0 platform Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 23/25] ASoC: amd: acp: amd-acp70-acpi-match: Add rt722 support Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 24/25] ASoC: amd: acp: amd-acp70-acpi-match: Add RT1320 & RT722 combination soundwire machine Vijendar Mukunda
2025-02-07 6:28 ` [PATCH V3 25/25] ASoC: amd: amd_sdw: Add quirks for Dell SKU's Vijendar Mukunda
2025-02-10 16:30 ` [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a799e6fa-5ef7-4e1b-993e-52555a73f2a8@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox