From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com,
prasad.kumpatla@oss.qualcomm.com, ajay.nandam@oss.qualcomm.com
Subject: Re: [PATCH v2 1/3] ASoC: qcom: audioreach: Fix lpaif_type configuration for the I2S interface
Date: Fri, 5 Sep 2025 11:46:45 +0100 [thread overview]
Message-ID: <a9eae2e3-0e75-4ffb-9de1-3b8a9bce86a6@oss.qualcomm.com> (raw)
In-Reply-To: <20250905104020.2463473-2-mohammad.rafi.shaik@oss.qualcomm.com>
On 9/5/25 11:40 AM, Mohammad Rafi Shaik wrote:
> Fix missing lpaif_type configuration for the I2S interface.
> The proper lpaif interface type required to allow DSP to vote
> appropriate clock setting for I2S interface.
>
> Fixes: 25ab80db6b133 ("ASoC: qdsp6: audioreach: add module configuration command helpers")
CC stable tag is missing.
--srini
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
> ---
> sound/soc/qcom/qdsp6/audioreach.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
> index bbfd51db8797..be21d5f6af8a 100644
> --- a/sound/soc/qcom/qdsp6/audioreach.c
> +++ b/sound/soc/qcom/qdsp6/audioreach.c
> @@ -995,6 +995,7 @@ static int audioreach_i2s_set_media_format(struct q6apm_graph *graph,
> param_data->param_id = PARAM_ID_I2S_INTF_CFG;
> param_data->param_size = ic_sz - APM_MODULE_PARAM_DATA_SIZE;
>
> + intf_cfg->cfg.lpaif_type = module->hw_interface_type;
> intf_cfg->cfg.intf_idx = module->hw_interface_idx;
> intf_cfg->cfg.sd_line_idx = module->sd_line_idx;
>
next prev parent reply other threads:[~2025-09-05 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 10:40 [PATCH v2 0/3] ASoC: qcom: Fix lpaif_type and DAI configuration for I2S interface Mohammad Rafi Shaik
2025-09-05 10:40 ` [PATCH v2 1/3] ASoC: qcom: audioreach: Fix lpaif_type configuration for the " Mohammad Rafi Shaik
2025-09-05 10:46 ` Srinivas Kandagatla [this message]
2025-09-05 11:05 ` Mohammad Rafi Shaik
2025-09-05 10:40 ` [PATCH v2 2/3] ASoC: qcom: q6apm-lpass-dais: Fix missing set_fmt DAI op for I2S Mohammad Rafi Shaik
2025-09-05 10:44 ` Srinivas Kandagatla
2025-09-05 10:40 ` [PATCH v2 3/3] ASoC: qcom: sc8280xp: Fix DAI format setting for MI2S interfaces Mohammad Rafi Shaik
2025-09-05 10:46 ` Srinivas Kandagatla
2025-09-05 11:12 ` Mohammad Rafi Shaik
2025-09-05 10:46 ` Konrad Dybcio
2025-09-05 11:28 ` Mohammad Rafi Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9eae2e3-0e75-4ffb-9de1-3b8a9bce86a6@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=prasad.kumpatla@oss.qualcomm.com \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox