From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Mark Brown <broonie@kernel.org>,
shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH AUTOSEL 6.1 6/9] ASoC: fsl_audmix: register card device depends on 'dais' property
Date: Fri, 18 Apr 2025 18:59:14 +0200 [thread overview]
Message-ID: <aAKE4kb6gImSpK5L@duo.ucw.cz> (raw)
In-Reply-To: <20250331145642.1706037-6-sashal@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
Hi!
> [ Upstream commit 294a60e5e9830045c161181286d44ce669f88833 ]
>
> In order to make the audmix device linked by audio graph card, make
> 'dais' property to be optional.
>
> If 'dais' property exists, then register the imx-audmix card driver.
> otherwise, it should be linked by audio graph card.
This is part of series, AFAICT; should we have it in -stable?
Best regards,
Pavel
> +++ b/sound/soc/fsl/fsl_audmix.c
> @@ -492,11 +492,17 @@ static int fsl_audmix_probe(struct platform_device *pdev)
> goto err_disable_pm;
> }
>
> - priv->pdev = platform_device_register_data(dev, "imx-audmix", 0, NULL, 0);
> - if (IS_ERR(priv->pdev)) {
> - ret = PTR_ERR(priv->pdev);
> - dev_err(dev, "failed to register platform: %d\n", ret);
> - goto err_disable_pm;
> + /*
> + * If dais property exist, then register the imx-audmix card driver.
> + * otherwise, it should be linked by audio graph card.
> + */
> + if (of_find_property(pdev->dev.of_node, "dais", NULL)) {
> + priv->pdev = platform_device_register_data(dev, "imx-audmix", 0, NULL, 0);
> + if (IS_ERR(priv->pdev)) {
> + ret = PTR_ERR(priv->pdev);
> + dev_err(dev, "failed to register platform: %d\n", ret);
> + goto err_disable_pm;
> + }
> }
>
> return 0;
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2025-04-18 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250331145642.1706037-1-sashal@kernel.org>
2025-03-31 14:56 ` [PATCH AUTOSEL 6.1 4/9] ALSA: hda: intel: Fix Optimus when GPU has no sound Sasha Levin
2025-03-31 14:56 ` [PATCH AUTOSEL 6.1 5/9] ALSA: hda: intel: Add Lenovo IdeaPad Z570 to probe denylist Sasha Levin
2025-03-31 14:56 ` [PATCH AUTOSEL 6.1 6/9] ASoC: fsl_audmix: register card device depends on 'dais' property Sasha Levin
2025-04-18 16:59 ` Pavel Machek [this message]
2025-03-31 14:56 ` [PATCH AUTOSEL 6.1 8/9] ALSA: usb-audio: Fix CME quirk for UF series keyboards Sasha Levin
2025-03-31 14:56 ` [PATCH AUTOSEL 6.1 9/9] ASoC: amd: Add DMI quirk for ACP6X mic support Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAKE4kb6gImSpK5L@duo.ucw.cz \
--to=pavel@denx.de \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=perex@perex.cz \
--cc=sashal@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox