From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com,
peter.ujfalusi@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
pierre-louis.bossart@linux.dev, Vijendar.Mukunda@amd.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 2/2] ASoC: Intel: sof_sdw: Don't bother to set platform string
Date: Mon, 5 May 2025 09:24:47 +0100 [thread overview]
Message-ID: <aBh1z9HufYwwVZQZ@opensource.cirrus.com> (raw)
In-Reply-To: <aBawJxaiReagn596@finisterre.sirena.org.uk>
On Sun, May 04, 2025 at 09:09:11AM +0900, Mark Brown wrote:
> On Tue, Apr 29, 2025 at 10:39:31AM +0100, Charles Keepax wrote:
> > The static platform_component name string is overwritten on card tear
> > down which will cause a NULL check on it to fail when the driver is
> > reprobed. However, it turns out that the ASoC core sets this string for
> > all topology systems anyway (after the aforementioned NULL check). So
> > there is no need for the machine driver to set the platform at all,
> > replace all the platform_component stuff with some simple place holders.
> >
> > Fixes: 52db12d193d4 ("ASoC: Intel: boards: add sof_sdw machine driver")
>
> Similarly here, this seems like more of a cleanup?
unbind then bind does fail here, so I think the fixes tag is good here, however
I will try to rephrase the commit message a little for v2.
Thanks,
Charles
next prev parent reply other threads:[~2025-05-05 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 9:39 [PATCH 1/2] ASoC: sdw_utils: Remove num_platforms from simple DAI helper Charles Keepax
2025-04-29 9:39 ` [PATCH 2/2] ASoC: Intel: sof_sdw: Don't bother to set platform string Charles Keepax
2025-05-04 0:09 ` Mark Brown
2025-05-05 8:24 ` Charles Keepax [this message]
2025-05-04 0:08 ` [PATCH 1/2] ASoC: sdw_utils: Remove num_platforms from simple DAI helper Mark Brown
2025-05-05 8:23 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBh1z9HufYwwVZQZ@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox