[PATCH] ALSA: hda: acpi: Make driver's match data const static

[PATCH] ALSA: hda: acpi: Make driver's match data const static

[Takashi Iwai]

The driver's match data, nvidia_hda_data, is referred only locally,
and should be static.  Also, as it's a read-only data, it can be
gracefully const, too.

Fixes: 4b214c9bbe26 ("ALSA: hda - Add new driver for HDA controllers listed via ACPI")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505230426.k8ruTgnr-lkp@intel.com/
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/hda_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/hda_acpi.c b/sound/pci/hda/hda_acpi.c
index 513f8fde198b..505cc97e0ee9 100644
--- a/sound/pci/hda/hda_acpi.c
+++ b/sound/pci/hda/hda_acpi.c
@@ -296,7 +296,7 @@ static const struct dev_pm_ops hda_acpi_pm = {
 	SYSTEM_SLEEP_PM_OPS(hda_acpi_suspend, hda_acpi_resume)
 };
 
-struct hda_data nvidia_hda_data = {
+static const struct hda_data nvidia_hda_data = {
 	.short_name = "NVIDIA",
 	.long_name = "NVIDIA HDA Controller",
 	.flags = AZX_DCAPS_CORBRP_SELF_CLEAR,
-- 
2.49.0

Re: [PATCH] ALSA: hda: acpi: Make driver's match data const static

[Daniel Dadap]

Reviewed-by: Daniel Dadap <ddadap@nvidia.com>

On Thu, May 22, 2025 at 10:52:51PM +0200, Takashi Iwai wrote:
> The driver's match data, nvidia_hda_data, is referred only locally,
> and should be static.  Also, as it's a read-only data, it can be
> gracefully const, too.
> 
> Fixes: 4b214c9bbe26 ("ALSA: hda - Add new driver for HDA controllers listed via ACPI")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505230426.k8ruTgnr-lkp@intel.com/
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/pci/hda/hda_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_acpi.c b/sound/pci/hda/hda_acpi.c
> index 513f8fde198b..505cc97e0ee9 100644
> --- a/sound/pci/hda/hda_acpi.c
> +++ b/sound/pci/hda/hda_acpi.c
> @@ -296,7 +296,7 @@ static const struct dev_pm_ops hda_acpi_pm = {
>  	SYSTEM_SLEEP_PM_OPS(hda_acpi_suspend, hda_acpi_resume)
>  };
>  
> -struct hda_data nvidia_hda_data = {
> +static const struct hda_data nvidia_hda_data = {
>  	.short_name = "NVIDIA",
>  	.long_name = "NVIDIA HDA Controller",
>  	.flags = AZX_DCAPS_CORBRP_SELF_CLEAR,
> -- 
> 2.49.0
>