linux-sound.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
	yung-chuan.liao@linux.intel.com, peter.ujfalusi@linux.intel.com,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v5 4/6] ASoC: SDCA: Create DAPM widgets and routes from DisCo
Date: Tue, 13 May 2025 10:56:45 +0100	[thread overview]
Message-ID: <aCMXXaF56CAKEHGX@opensource.cirrus.com> (raw)
In-Reply-To: <470de11c-82b1-4d1f-aa52-e0849ea261e1@linux.dev>

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

On Mon, May 12, 2025 at 03:46:40PM +0200, Pierre-Louis Bossart wrote:
> On 5/12/25 14:42, Charles Keepax wrote:
> It's been a while since I reviewed an earlier versions so now I am confused.

I have attached the output of the dapm-graph tool for the UAJ
component for one of our devices, whilst a headset is connected.
Hopefully this will help to make it a little more clear what
the generated graph from this code looks like. Hopefully the
attachment makes it through the ether, let me know if it doesn't
and I can send directly.

The PDE supply widgets are what control the PDE power registers,
they will power up when they are attached to an active path, ie.
a valid link between an active source and an active sink.

For the streaming terminals IT41,OT36 they are active when the
audio stream is open. For the non-streaming ones
IT31,IT32,IT33,OT43,OT44,OT45 these are active when the pin
switch is enabled which it is by default, without pin switches
these would be always active. The pin switches are not shown
on the output of dapm-graph.

You can see the effect of the GE control, where it has set the
input of SU35 to FU33, by the selection of "Headset". And you can
see the virtual mixer switches going into MU35, currently both
Mixer 1 and 2 are on, so you can see the paths connected.

But as you can see the correlation to the function diagrams is
the spec is pretty good. As I noted with a few minor exceptions,
like the GE having more paths, since it must connect to all the
widgets it controls separately. And the DAI widgets that are
created by the DAPM core.

Thanks,
Charles

[-- Attachment #2: test.png --]
[-- Type: image/png, Size: 101091 bytes --]

  parent reply	other threads:[~2025-05-13  9:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-12 12:42 [PATCH v5 0/6] Add DAPM/ASoC helpers to create SDCA drivers Charles Keepax
2025-05-12 12:42 ` [PATCH v5 1/6] ASoC: SDCA: Remove regmap module macros Charles Keepax
2025-05-12 12:42 ` [PATCH v5 2/6] ASoC: SDCA: Move allocation of PDE delays array Charles Keepax
2025-05-12 12:42 ` [PATCH v5 3/6] ASoC: dapm: Add component level pin switches Charles Keepax
2025-05-12 12:42 ` [PATCH v5 4/6] ASoC: SDCA: Create DAPM widgets and routes from DisCo Charles Keepax
2025-05-12 13:46   ` Pierre-Louis Bossart
2025-05-12 17:08     ` Charles Keepax
2025-05-14 12:15       ` Pierre-Louis Bossart
2025-05-14 13:30         ` Charles Keepax
2025-05-15 14:50           ` Charles Keepax
2025-05-19 17:53             ` Pierre-Louis Bossart
2025-05-13  9:56     ` Charles Keepax [this message]
2025-05-14 12:33       ` Pierre-Louis Bossart
2025-05-14 13:33         ` Charles Keepax
2025-05-12 12:42 ` [PATCH v5 5/6] ASoC: SDCA: Create ALSA controls " Charles Keepax
2025-05-12 13:53   ` Pierre-Louis Bossart
2025-05-12 17:14     ` Charles Keepax
2025-05-13 10:24       ` Charles Keepax
2025-05-14 12:39         ` Pierre-Louis Bossart
2025-05-14 13:35           ` Charles Keepax
2025-05-14 12:19       ` Pierre-Louis Bossart
2025-05-12 12:42 ` [PATCH v5 6/6] ASoC: SDCA: Create DAI drivers " Charles Keepax
2025-05-12 14:00   ` Pierre-Louis Bossart
2025-05-12 17:16     ` Charles Keepax
2025-05-14 12:38       ` Pierre-Louis Bossart
2025-05-14 13:35         ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aCMXXaF56CAKEHGX@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).