From: Vinod Koul <vkoul@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: broonie@kernel.org, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.dev, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, krzysztof.kozlowski@linaro.org,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 0/4] ASoC: codecs: wcd937x/8x/9x: cleanup
Date: Wed, 20 Aug 2025 22:49:20 +0530 [thread overview]
Message-ID: <aKYDmBYyQI2TjTQ6@vaman> (raw)
In-Reply-To: <19494b00-a5b9-4490-bddb-48f48e73b0ac@oss.qualcomm.com>
On 15-08-25, 06:32, Srinivas Kandagatla wrote:
> Hi Vinod,
> On 7/4/25 1:12 PM, srinivas.kandagatla@oss.qualcomm.com wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> >
> > All these 3 codecs have been duplicating two of the soundwire
> > functions. Noticed another new driver starting to do the same, its time
> > to make some helpers so that we do not duplicate these functions.
> >
> > I have added two helpers of_sdw_find_device_by_node() and
> > sdw_slave_get_current_bank() in soundwire layer for the codecs to use them.
> >
> > Changes since v1:
> > - updated sdw_slave_get_current_bank do error checks on read
> >
> > Srinivas Kandagatla (4):
> > soundwire: bus: add of_sdw_find_device_by_node helper
> > soundwire: bus: add sdw_slave_get_current_bank helper
>
>
> Do you have any comments these two soundwire patches in this series?
Yes I am nota helpers like this, but I dont think it is big deal so:
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
prev parent reply other threads:[~2025-08-20 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 12:12 [PATCH v2 0/4] ASoC: codecs: wcd937x/8x/9x: cleanup srinivas.kandagatla
2025-07-04 12:12 ` [PATCH v2 1/4] soundwire: bus: add of_sdw_find_device_by_node helper srinivas.kandagatla
2025-10-13 5:44 ` Vinod Koul
2025-07-04 12:12 ` [PATCH v2 2/4] soundwire: bus: add sdw_slave_get_current_bank helper srinivas.kandagatla
2025-07-04 14:18 ` Dmitry Baryshkov
2025-07-04 12:12 ` [PATCH v2 3/4] ASoC: codecs: wcdxxxx: use of_sdw_find_device_by_node helper srinivas.kandagatla
2025-07-04 12:12 ` [PATCH v2 4/4] ASoC: codecs: wcdxxxx: use sdw_slave_get_current_bank helper srinivas.kandagatla
2025-07-04 14:18 ` Dmitry Baryshkov
2025-08-15 5:32 ` [PATCH v2 0/4] ASoC: codecs: wcd937x/8x/9x: cleanup Srinivas Kandagatla
2025-08-20 17:19 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKYDmBYyQI2TjTQ6@vaman \
--to=vkoul@kernel.org \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.dev \
--cc=srinivas.kandagatla@oss.qualcomm.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox