From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C720F1D63CD for ; Fri, 26 Sep 2025 04:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758859398; cv=none; b=g+axbNC4mOv84/chJrecrWstEJvFVd5yuiuN5/7zCAl2pg+dhl4Rsj0j1UDAF+Wi7E6XZOaSVMc7kfTAkI2P3eQRPw0UirgYFhTBEqRHduYM3IrD0gdIAT+ms/HURSg8zYajMT42ht8G4V2nawaqUPPjTKIMbO3uQgqeAO2GquU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758859398; c=relaxed/simple; bh=wvhzxABFdiOg+ADsIFkLjfPZXMEFheR4Ig6WrpOZQwI=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=hXQ/uztn3ypIBf51/p8j1Hfhi+ByiPcgS0bgsJVIZkamTwZGefkksC03hNStGxxNMyDTBWa4acVFEANVjg+ggkDRBz08ASLu5B36ZUIANybhms7KuFQ4y0MUOB6C0YYZAoHeJ15+yoXlY4DhU6EBwstlv0jYAywfi6imd0/m3mE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Em2hV96b; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Em2hV96b" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3ece0e4c5faso1627586f8f.1 for ; Thu, 25 Sep 2025 21:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758859395; x=1759464195; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SytoPnG5QJz686o335sBi4HCtgv9sYZ8aX3hOtRMKuU=; b=Em2hV96bno6K4j3EiQ4i+vWldVz172Jhassul+IUdwIrwuSktCax0xo/EEMeA7glUz N7rjfp3f1Xm6dwKznrnCoz31TTXrJs7xjXAX//HulS53XAizOxcDv4qL8TwZGgRcWXD2 DYmRqH+VbbyP9qx8/29UsGgz6UF4zTr/JzruhLh+qeR7OH5uxB8J8UrNIPc7r+jYinq1 Vrtz+W9/A6V/OEo0QDx8C0e5QM1wnda3PpQTt9snHBkozlteFwk1kWVrFYOvBhRTFL6n j+BCcvbGGjbin8Bw7a2OlOrWGMy8Ug3MFbIwV7ywrKjWi6wYE/uiMRDS4OWSotjA5yEB PE4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758859395; x=1759464195; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SytoPnG5QJz686o335sBi4HCtgv9sYZ8aX3hOtRMKuU=; b=gnSEWK/KJ3L3uOe/NSb1Vt39M/uRYmsQKq4olGjuRH5VQZhws00N0swLGAbP70EmY/ 6wRtblFvj4EJmu0NyslqxBc5qMLgz4dHCYRjW3DW3LK0WgWEfIW6avG6yQOJBjdBQRIr sd/anYN28CvR9YR6ai6aMRUHEy1hHY0Wm4m/f5/II1O7MLx8no75k6XMDU/RlPhwscAE UGBqHBfmQZz9WDBS0Hh1lhqN6iY46hS3sjt3J089aBLYMGlW9aWYUdiylimv4ARO7Gwv 8AZbXbIXpNNuUjBFAdT5YC+WuH7XtZLzSzVgDmtq02SuzCrhhaanNB7vgxu9eSaZOsrc 1arw== X-Forwarded-Encrypted: i=1; AJvYcCXw7MbmC0qtVA4t9mw3jfcrSwmjNiRI/hbiNqq9F3O0eepzkMg05ljYUeOTUndrTbyeDwZNotNwKfihvQ==@vger.kernel.org X-Gm-Message-State: AOJu0YyevsixgfexFGbFsxGldcMoQtCZ26ABxRKlUGtYZbnRC//u1sbW DsM0Pu80TlGQK+7vtJ8nMG68nA45iHAd/NvPmPlgJ4jJwzZZhNKQHEN9PrOHblcmQkI= X-Gm-Gg: ASbGnct5M0gKkLppKf3/HE56FULZvOB7EwJsnOUUcT6XYFxipeebDjhHgJfjKDDn0yV Dx3jpamt8h8tzF6Quk5bQXJpRYUYQgsUcffzSJ0ZWobOFClLd0dHxR8SJarvcUcGmCo2/SoWig2 Cr25rTj/bHL93nN3mydDdbeYCeFd6v7vnsYdWHl5Kpka0eFNDfITKUyhl5oCLhatl4UYMOtcBEL w+m5dZ8bt/P6Xr9X8MrisAiIk2875vB4UrArzhVQEiuC2yWBKUz1NvGrh7v3xHj5wP+MCgJwtR2 +gdVmts9JMg22t7cbw28KvmhtHcoUjVOCDUTxd84Kmxb3TFOT7i5dnKqaLKCeXpmzdEaLiMmrvx GpJ7Ue4VhdyNx/8BE+1okvyj6VTvi5gU/v8hmCvg= X-Google-Smtp-Source: AGHT+IHNqzt+aianVVfPntORZwd/WnwppYwAnuoO1k+luridVLwZ4XnvDsMlhkTtJ7/8EeWUMuSP4A== X-Received: by 2002:a05:6000:2484:b0:3f0:9bf0:a369 with SMTP id ffacd0b85a97d-40e43b08823mr5542343f8f.14.1758859394949; Thu, 25 Sep 2025 21:03:14 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-40fb89fb2fcsm5697497f8f.22.2025.09.25.21.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Sep 2025 21:03:14 -0700 (PDT) Date: Fri, 26 Sep 2025 07:03:11 +0300 From: Dan Carpenter To: Niranjan H Y Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Bard Liao , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] ASoc: tas2783A: Fix an error code in probe() Message-ID: Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding This code returns the wrong variable "tas_dev->regmap" instead of "regmap" so it returns success instead of a negative error code. Return the correct variable. Fixes: 4cc9bd8d7b32 ("ASoc: tas2783A: Add soundwire based codec driver") Signed-off-by: Dan Carpenter --- sound/soc/codecs/tas2783-sdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2783-sdw.c b/sound/soc/codecs/tas2783-sdw.c index 3e03e68932f6..21cdcf93bbef 100644 --- a/sound/soc/codecs/tas2783-sdw.c +++ b/sound/soc/codecs/tas2783-sdw.c @@ -1285,7 +1285,7 @@ static s32 tas_sdw_probe(struct sdw_slave *peripheral, &tas_regmap, &tas2783_mbq_cfg); if (IS_ERR(regmap)) - return dev_err_probe(dev, PTR_ERR(tas_dev->regmap), + return dev_err_probe(dev, PTR_ERR(regmap), "Failed devm_regmap_init_sdw."); /* keep in cache until the device is fully initialized */ -- 2.51.0