From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ACEF31960D for ; Fri, 24 Oct 2025 11:25:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761305148; cv=none; b=Yi3e44wEl88eE4diF9fhE0skYQ+EpeZZHeM9fqaF8qQzx55Xz432Sa+geh03+KnNqf5Kbbeu2wTL/YvKeCo++I23ZMMOfk5xsbxaWWl4oYfKHhu7QiDmvILqd89FiiGg4FBe8in36gZe6j1MByL3Zrt0Hi7C29VUT25s4gj2Gg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761305148; c=relaxed/simple; bh=ZAs04S7e6L0yM5gZ4z8BuM0hDmPUY26t3U7lZ2eGr+U=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=tsIbpOoIuqPlhhAImmOPP6evUBgFN25clH9remqZ4QBg4Yho4VRBkNdaQRLVzgQc9y1VE/YaclBLG2W7c6Kk/qD775ja5bD7jHc5ieECNcKkjk0mZLfUZffr5oNRFkHUTlBdE0X/omnn23/oMiPVRhd0+YhrOsn8jrNWmdGXkkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ttjCVmbw; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ttjCVmbw" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-4270a0127e1so1388930f8f.3 for ; Fri, 24 Oct 2025 04:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761305145; x=1761909945; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=uNeE/cHbHg6zZnCX2aCbRT+il/304F0EXYg7yJD4/Vg=; b=ttjCVmbw6JTVEttyFPKj/8LRzgbawarY1zNK7dbDxu0kNyAYC5rpbbp0xu9ViIX4l5 D8QrHLU4gGFnMwXNimIf0a8BC4UeyQ1By5JQzp4t86ZuMqaMD+zpaunXyXYcpIV/ahRG penECmeo732tCsE29xbJc2LVK52axqi/U+ulwZEnIbjn+1AYLy0diUtaRUhWuoVrFA35 zAmx68DuxYi7gy0I4gb9yGpA4PfXFB4LI3kSAl39x38VzHKBWMfITo8mCCme3QXEgvGG 5NFqcZ2VxXkpsYPBLI8tzaOwatwO3YyloH92hZ8oFbp2qPopsUpkIpQQVrF7wOhbWj0R QyEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761305145; x=1761909945; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uNeE/cHbHg6zZnCX2aCbRT+il/304F0EXYg7yJD4/Vg=; b=R6yq9RTpmUL1DVJo9nF4Oh25xIMzYOAfXACFqsqBIyVg6yk+ljGgjHNTC5Bkk3yQ+/ amOKg4cXltn6j7nP04ntf+6SJ6msYVw9Ss3duO3sJV0bmTZ2QB/8hQtQjqN+hBR27Sja khhIy8gBTwNVEO+jjcd2XUjGsGPTPYf7ycCwe7DmK0AGHzLjeAtW2Kpkom5JsGYY59wR SB7tm2XvpRy20tc/CL2j1cDqdnnjbTFaUr8ncMopyOtS6uWd4oNQXBp9/NHEU7DOKjBV 0aARSxb7vMaqkBd1ZUpNWmamOgQgsg9x48+Whwt9wWJsipQr+RuSMWX9TtKAmWYgDZDj 2ZNA== X-Gm-Message-State: AOJu0YyTQep1785hA8Lrd1FKn0YBTJaF/bqMBUTe39SCGxYEw/o/dQsM d4LlvxzUIAX9Mo16SyktUH6iA7zUU1adA+FzF6ECoDqgzTPZDv89QDh/cAYuHJNKesA= X-Gm-Gg: ASbGncvbE0jtpmPQCqqr5bOaX+qhl/tSNqDk7yJs1z3QqNqAvvM6t7ITZex4mbp8xt7 4mVAGveorcaxPxf3/zBVLagr0FD1wXK0PbIBeRbUIBvdmv5uqNjYRP0ss5cHU4k5hUuckUAhAh+ Sor4V5aoHXCo3LsNzzxP2XIK+Xhc2ibm4TwgJjR4Bv1rTcJAU4v5/fa+8OATg9S0dw77NJopoH4 r1ikyfOUnCNHrg4xJf0Ob+oDl1e8KwrEtUjv5ZvZnUElI8RvRaHiWfG0maXri259VfyaqqU3NpS 7pEcZQ4/5PcRabNpI5XrZbcF3IDRhX2QZPE207VPmySig3xX/Yj4/C3agvaO+NpfIzNX+PwNEia XMmgQf6OU/8DUunE2hAfUrcO0hrCpAtkfwYGDgflQbF6lj+hFwYJ9ZDIzeMezHzZMR9OGwTs6yC v638xcTeRj6HvIPv0P X-Google-Smtp-Source: AGHT+IH4BOOMng7wIY/cWDbuAz1zzM1xjBdhfECUjKsYQl6JyeafHNEV0BuRxCbd43qEQDsevg4+ag== X-Received: by 2002:a05:6000:2c04:b0:428:4004:8241 with SMTP id ffacd0b85a97d-4284004abcdmr13747779f8f.40.1761305144643; Fri, 24 Oct 2025 04:25:44 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-429897e763csm8893712f8f.6.2025.10.24.04.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Oct 2025 04:25:44 -0700 (PDT) Date: Fri, 24 Oct 2025 14:25:40 +0300 From: Dan Carpenter To: Troy Mitchell Cc: linux-sound@vger.kernel.org, spacemit@lists.linux.dev Subject: [bug report] ASoC: spacemit: add i2s support for K1 SoC Message-ID: Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello Troy Mitchell, Commit fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC") from Oct 17, 2025 (linux-next), leads to the following Smatch static checker warning: sound/soc/spacemit/k1_i2s.c:435 spacemit_i2s_probe() error: uninitialized symbol 'dai'. sound/soc/spacemit/k1_i2s.c 389 static int spacemit_i2s_probe(struct platform_device *pdev) 390 { 391 struct snd_soc_dai_driver *dai; 392 struct spacemit_i2s_dev *i2s; 393 struct resource *res; 394 struct clk *clk; 395 int ret; 396 397 i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL); 398 if (!i2s) 399 return -ENOMEM; 400 401 i2s->dev = &pdev->dev; 402 403 i2s->sysclk = devm_clk_get_enabled(i2s->dev, "sysclk"); 404 if (IS_ERR(i2s->sysclk)) 405 return dev_err_probe(i2s->dev, PTR_ERR(i2s->sysclk), 406 "failed to enable sysbase clock\n"); 407 408 i2s->bclk = devm_clk_get_enabled(i2s->dev, "bclk"); 409 if (IS_ERR(i2s->bclk)) 410 return dev_err_probe(i2s->dev, PTR_ERR(i2s->bclk), "failed to enable bit clock\n"); 411 412 clk = devm_clk_get_enabled(i2s->dev, "sspa_bus"); 413 if (IS_ERR(clk)) 414 return dev_err_probe(i2s->dev, PTR_ERR(clk), "failed to enable sspa_bus clock\n"); 415 416 i2s->sspa_clk = devm_clk_get_enabled(i2s->dev, "sspa"); 417 if (IS_ERR(clk)) 418 return dev_err_probe(i2s->dev, PTR_ERR(clk), "failed to enable sspa clock\n"); 419 420 i2s->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); 421 if (IS_ERR(i2s->base)) 422 return dev_err_probe(i2s->dev, PTR_ERR(i2s->base), "failed to map registers\n"); 423 424 i2s->reset = devm_reset_control_get_exclusive(&pdev->dev, NULL); 425 if (IS_ERR(i2s->reset)) 426 return dev_err_probe(i2s->dev, PTR_ERR(i2s->reset), 427 "failed to get reset control"); 428 429 dev_set_drvdata(i2s->dev, i2s); 430 431 spacemit_i2s_init_dai(i2s, &dai, res->start + SSDATR); ^^^^ dai is not initialized on failure. Generally in the kernel we always check for allocation failures. Even when they can't happen in real life. I was hoping they were going to make a rule that allocations under 4k wouldn't have to be checked but it hasn't happened yet. 432 433 ret = devm_snd_soc_register_component(i2s->dev, 434 &spacemit_i2s_component, --> 435 dai, 1); 436 if (ret) 437 return dev_err_probe(i2s->dev, ret, "failed to register component"); 438 439 return devm_snd_dmaengine_pcm_register(&pdev->dev, &spacemit_dmaengine_pcm_config, 0); 440 } regards, dan carpenter