From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: hariconscious@gmail.com
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, khalid@kernel.org, shuah@kernel.org,
david.hunter.linux@gmail.com, kuninori.morimoto.gx@renesas.com,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: codec: wm8400: replace printk() calls with dev_*() device aware logging
Date: Thu, 30 Oct 2025 11:07:06 +0000 [thread overview]
Message-ID: <aQNG2q+0CLFQ50yq@opensource.cirrus.com> (raw)
In-Reply-To: <20251025043011.598300-1-hariconscious@gmail.com>
On Sat, Oct 25, 2025 at 10:00:11AM +0530, hariconscious@gmail.com wrote:
> From: HariKrishna Sagala <hariconscious@gmail.com>
>
> Replace direct printk() calls with the appropriate dev_*() logging
> APIs.Use dev_err, dev_warn, dev_info, or dev_dbg to reflect the correct
> severity level. Pass the canonical struct device pointer so logs
> include device context and become traceable to specific hardware
> instances.Improve log clarity, make messages filterable by device
> and align the driver with kernel logging conventions to aid
> debugging and maintenance.
>
> Signed-off-by: HariKrishna Sagala <hariconscious@gmail.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2025-10-30 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-25 4:30 [PATCH] ASoC: codec: wm8400: replace printk() calls with dev_*() device aware logging hariconscious
2025-10-30 11:07 ` Charles Keepax [this message]
2025-10-30 14:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQNG2q+0CLFQ50yq@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.hunter.linux@gmail.com \
--cc=hariconscious@gmail.com \
--cc=khalid@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox