Re: [PATCH v1] ASoC: SDCA: bug fix while parsing mipi-sdca-control-cn-list

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Mon, Nov 10, 2025 at 06:30:58PM +0530, Niranjan H Y wrote:
> "struct sdca_control" declares "values" field as integer array.
> But the memory allocated to it is of char array. This causes
> crash for sdca_parse_function API. This patch addresses the
> issue by allocating correct data size.
> 
> Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
> ---

Thanks very much for spotting this.

>  sound/soc/sdca/sdca_functions.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_functions.c
> index b2e3fab9b..6975c71a9 100644
> --- a/sound/soc/sdca/sdca_functions.c
> +++ b/sound/soc/sdca/sdca_functions.c
> @@ -950,7 +950,8 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti
>  		return ret;
>  	}
>  
> -	control->values = devm_kzalloc(dev, hweight64(control->cn_list), GFP_KERNEL);
> +	control->values = devm_kzalloc(dev, hweight64(control->cn_list) * sizeof(int),
> +				       GFP_KERNEL);

Should probably switch to devm_kcalloc, rather than doing the
multiply manually.

Thanks,
Charles

>  	if (!control->values)
>  		return -ENOMEM;
>  
> -- 
> 2.25.1
>