From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Baojun Xu <baojun.xu@ti.com>
Cc: tiwai@suse.de, hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
broonie@kernel.org, alsa-devel@alsa-project.org,
shenghao-ding@ti.com, 13916275206@139.com,
platform-driver-x86@vger.kernel.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, letitia.tsai@hp.com
Subject: Re: [PATCH v2] platform/x86: serial-multi-instantiate: IRQ_RESOURCE_AUTO should be compatible with IRQ_RESOURCE_NONE
Date: Tue, 25 Nov 2025 11:25:11 +0200 [thread overview]
Message-ID: <aSV190mwCKZ6WOoA@smile.fi.intel.com> (raw)
In-Reply-To: <20251125084436.8381-1-baojun.xu@ti.com>
On Tue, Nov 25, 2025 at 04:44:36PM +0800, Baojun Xu wrote:
> The tas2781-hda supports multi-projects, in some projects,
> no irq is required, so the IRQ_RESOURCE_AUTO should be compatible
> with IRQ_RESOURCE_NONE.
TL;DR: NAK.
It will relax the conditions for the devices where IRQ is required.
Probably you need to consider DMI quirks or so.
Also you failed to provide the ACPI DSDT excerpts to show the real use case.
And what the board is that that uses polling mode?
You can also consider this approach (as a compromise between two:
#define IRQ_RESOURCE_OPTIONAL BIT(2)
...
switch (inst->flags & IRQ_RESOURCE_TYPE) {
case IRQ_RESOURCE_AUTO:
...
if (inst->flags & IRQ_RESOURCE_OPTIONAL)
ret = 0;
break;
...
}
...
{ "tas2781-hda", IRQ_RESOURCE_AUTO | IRQ_RESOURCE_OPTIONAL, 0 },
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-25 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 8:44 [PATCH v2] platform/x86: serial-multi-instantiate: IRQ_RESOURCE_AUTO should be compatible with IRQ_RESOURCE_NONE Baojun Xu
2025-11-25 9:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSV190mwCKZ6WOoA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=letitia.tsai@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox