From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Brad Kelley <spambake@bradkelley.org>
Cc: david.rhodes@cirrus.com, rf@opensource.cirrus.com,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Correct a typo which inverted the reset GPIO pin sequence.
Date: Thu, 11 Dec 2025 10:02:22 +0000 [thread overview]
Message-ID: <aTqWrhjVbySDTtQ6@opensource.cirrus.com> (raw)
In-Reply-To: <aTqRXbdAaV++jdHZ@opensource.cirrus.com>
On Thu, Dec 11, 2025 at 09:39:41AM +0000, Charles Keepax wrote:
> On Wed, Dec 10, 2025 at 09:16:28PM -0800, Brad Kelley wrote:
> > - gpiod_direction_output(cs4271->reset, 1);
> > + gpiod_direction_output(cs4271->reset, 0);
>
> This does look like a bug however, the GPIO should clearly still be
> an output. So keep this bit. Also could you change that commit in
> the commit message to a Fixes tag:
>
> Fixes: 42d1178d223b ("ASoC: cs4271: Convert to GPIO descriptors")
>
Apologies must still need my morning coffee this is the initial
output value, not the direction. So should also be covered by the
GPIO_ACTIVE_LOW flag.
Thanks,
Charles
next prev parent reply other threads:[~2025-12-11 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 5:16 [PATCH] Correct a typo which inverted the reset GPIO pin sequence Brad Kelley
2025-12-11 9:39 ` Charles Keepax
2025-12-11 10:02 ` Charles Keepax [this message]
2025-12-11 10:19 ` Richard Fitzgerald
2025-12-12 15:44 ` Brad Kelley
2025-12-12 16:03 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTqWrhjVbySDTtQ6@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=spambake@bradkelley.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox