From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
seppo.ingalsuo@linux.intel.com
Subject: Re: [PATCH 2/8] ASoC: SOF: ipc4-topology: Correct the allocation size for bytes controls
Date: Mon, 15 Dec 2025 23:12:24 +0900 [thread overview]
Message-ID: <aUAXSIIn7-ds8TNB@sirena.co.uk> (raw)
In-Reply-To: <20251215112048.16331-3-peter.ujfalusi@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]
On Mon, Dec 15, 2025 at 01:20:42PM +0200, Peter Ujfalusi wrote:
> The size of the data behind of scontrol->ipc_control_data for bytes
> controls is:
> [1] sizeof(struct sof_ipc4_control_data) + // kernel only struct
> [2] sizeof(struct sof_abi_hdr)) + payload
>
> The max_size specifies the size of [2] and it is coming from topology.
>
> Change the function to take this into account and allocate adequate amount
> of memory behind scontrol->ipc_control_data.
>
> With the change we will allocate [1] amount more memory to be able to hold
> the full size of data.
>
> Fixes: 1bfde5818266 ("ASoC: SOF: ipc4-topology: add byte kcontrol support")
Commit: e368b2ba332c ("ASoC: SOF: ipc4-control: Use the correct size for scontrol->ipc_control_data")
Fixes tag: Fixes: 03f537690f40 ("ASoC: sof: Improve sof_ipc4_bytes_ext_put function")
Has these problem(s):
- Target SHA1 does not exist
Commit: 7f256787a08a ("ASoC: SOF: ipc4-topology: Correct the allocation size for bytes controls")
Fixes tag: Fixes: 1bfde5818266 ("ASoC: SOF: ipc4-topology: add byte kcontrol support")
Has these problem(s):
- Target SHA1 does not exist
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-12-15 14:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 11:20 [PATCH 0/8] ASoC: SOF: ipoc4: Support for generic bytes controls Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 1/8] ASoC: SOF: ipc4-control: If there is no data do not send bytes update Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 2/8] ASoC: SOF: ipc4-topology: Correct the allocation size for bytes controls Peter Ujfalusi
2025-12-15 14:12 ` Mark Brown [this message]
2025-12-15 11:20 ` [PATCH 3/8] ASoC: SOF: ipc4-control: Use the correct size for scontrol->ipc_control_data Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 4/8] ASoC: SOF: ipc4-control: Keep the payload size up to date Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 5/8] ASoC: SOF: ipc4-topology: Set initial param_id for bytes control type Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 6/8] ASoC: SOF: ipc4: Support for sending payload along with LARGE_CONFIG_GET Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 7/8] ASoC: SOF: ipc4: Add definition for generic bytes control Peter Ujfalusi
2025-12-15 11:20 ` [PATCH 8/8] ASoC: SOF: ipc4-control: Add support " Peter Ujfalusi
2025-12-23 17:07 ` [PATCH 0/8] ASoC: SOF: ipoc4: Support for generic bytes controls Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUAXSIIn7-ds8TNB@sirena.co.uk \
--to=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=seppo.ingalsuo@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox