Re: [PATCH v3] ALSA: control: Verify put() result when in debug mode

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Fri, Feb 06, 2026 at 03:33:34PM +0100, Takashi Iwai wrote:
> Mark Brown wrote:

> > Might it be worth considering doing this via trace_printk() or possibly
> > tracepoints?  They're very low overhead and with tracepoints they're
> > strutured so they're more suitable for very high volume logging.

> If we want to record each kcontrol access indeed, then yes, I agree
> with tracepoint as the best way to go.  But, IIRC, trace_printk()
> leads to a kernel warning, so better to avoid.

It does cause a kernel warning, but given that this is only going to be
turned on with SND_DEBUG and probably shouldn't be on in production
(given the extra read on each write) that doesn't seem unreasonable?
I'm fairly sure tracepoints by themselves don't cause a warning (they're
there all the time in all my subsystems anyway) so would be more
suitable if the complaint about trace_printk() is an issue.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]