Re: [PATCH 4/4] ASoC: SDCA: Pull the Q7.8 volume helpers out of soc-ops

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Tue, Feb 24, 2026 at 01:55:16PM +0000, Richard Fitzgerald wrote:
> On 23/02/2026 9:54 am, Charles Keepax wrote:
> > It is cleaner to keep the SDCA code contained and not update the core
> > code for things that are unlikely to see reuse outside of SDCA. Move the
> > Q7.8 volume helpers back into the SDCA core code.
> > 
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > @@ -226,26 +203,17 @@ static int soc_put_volsw(struct snd_kcontrol *kcontrol,
> >   			 struct snd_ctl_elem_value *ucontrol,
> >   			 struct soc_mixer_control *mc, int mask, int max)
> >   {
> > -	unsigned int (*ctl_to_reg)(struct soc_mixer_control *, int, unsigned int, unsigned int, int);
> >   	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
> >   	unsigned int val1, val_mask;
> >   	unsigned int val2 = 0;
> >   	bool double_r = false;
> >   	int ret;
> > -	if (mc->sdca_q78) {
> > -		ctl_to_reg = sdca_soc_q78_ctl_to_reg;
> > -		val_mask = mask;
> > -	} else {
> > -		ctl_to_reg = soc_mixer_ctl_to_reg;
> > -		val_mask = mask << mc->shift;
> Still need this line to initialize val_mask.

Thanks Richard, will get that fixed up today.

Thanks,
Charles