From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="g9HGqjQw" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95992F9; Sun, 10 Dec 2023 01:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702199303; bh=UyGBRvLWUM+789VmXNV+b0ScFXqSOt3aVS77AL3sTnE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=g9HGqjQwhAEv3DnDab1BQxmoJgBhkhlP8VQ+W5S7T5E8575/AVw/VAoCGJBfPPeGZ qzm3tgpa4mCi8g32cfV7+2PNgDFA8vNgneRy1iMMAzTaQ+jZg20Oghv3+5OAYTRhPg sXvwu+oe8ViRkhGt9if0Z6eMnklu1HxiARsL5rN4k4OWJRFj6250uvciFii2izr2XW w6hj1o4CJlnFQt99uFiM8aB3j+iUuJ228SeMS1SiLGcvmhgZ+d6ktvh6Iul598fHXh oTrnUGplDaIam0owEHZqcG/lvWh40VqYRt3WCQhV33maNOo7mh+/1klwpnuVXhV9vK gqGqYz6NHHKrw== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id C10E037813EB; Sun, 10 Dec 2023 09:08:21 +0000 (UTC) Message-ID: Date: Sun, 10 Dec 2023 11:08:21 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT Content-Language: en-US To: Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Alper Nebi Yasak , Syed Saba Kareem , Kuninori Morimoto , Marian Postevca , Vijendar Mukunda , V sujith kumar Reddy , Mastan Katragadda , Ajit Kumar Pandey Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org, kernel@collabora.com References: <20231209205351.880797-1-cristian.ciocaltea@collabora.com> <20231209205351.880797-12-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/10/23 05:30, Venkata Prasad Potturu wrote: > > On 12/10/23 02:23, Cristian Ciocaltea wrote: >> Commit efb931cdc4b9 ("ASoC: SOF: topology: Add support for AMD ACP >> DAIs") registered "ACP" name for SOF_DAI_AMD_BT DAI type.  However, some >> boards, i.e. Steam Deck OLED, seem to require "ACPBT" for the same type: >> >> [  467.489680] snd_sof_amd_vangogh 0000:04:00.5: ipc tx error for >> 0x30030000 (msg/reply size: 16/0): -22 >> [  467.492775] snd_sof_amd_vangogh 0000:04:00.5: sof_ipc3_route_setup: >> route ACPBT2.IN -> BUF5.0 failed >> [  467.495839] snd_sof_amd_vangogh 0000:04:00.5: >> sof_ipc3_set_up_all_pipelines: route set up failed >> [  467.499128] snd_sof_amd_vangogh 0000:04:00.5: error: tplg component >> load failed -22 >> [  467.502210] snd_sof_amd_vangogh 0000:04:00.5: error: failed to load >> DSP topology -22 >> [  467.505289] snd_sof_amd_vangogh 0000:04:00.5: ASoC: error at >> snd_soc_component_probe on 0000:04:00.5: -22 >> [  467.508430] sof_mach nau8821-max: ASoC: failed to instantiate card -22 >> [  467.511725] sof_mach nau8821-max: error -EINVAL: Failed to register >> card(sof-nau8821-max) >> [  467.514861] sof_mach: probe of nau8821-max failed with error -22 >> >> Add "ACPBT" alias for "ACP" SOF DAI type. >> >> Signed-off-by: Cristian Ciocaltea >> --- >>   sound/soc/sof/topology.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c >> index e3e7fbe40fa6..73bf791e7520 100644 >> --- a/sound/soc/sof/topology.c >> +++ b/sound/soc/sof/topology.c >> @@ -290,6 +290,7 @@ static const struct sof_dai_types sof_dais[] = { >>       {"SAI", SOF_DAI_IMX_SAI}, >>       {"ESAI", SOF_DAI_IMX_ESAI}, >>       {"ACP", SOF_DAI_AMD_BT}, >> +    {"ACPBT", SOF_DAI_AMD_BT}, > No need to create the alias name, we can directly modify ACP to ACPBT as > ACP is not using anywhere. Great, thanks, will do in v2. >>       {"ACPSP", SOF_DAI_AMD_SP}, >>       {"ACPDMIC", SOF_DAI_AMD_DMIC}, >>       {"ACPHS", SOF_DAI_AMD_HS},