Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: sashiko-reviews@lists.linux.dev, Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: cs35l56: Add KUnit test that widget init doesn't write ASP registers
Date: Tue, 17 Nov 2026 14:22:28 +0000	[thread overview]
Message-ID: <aa8c43bd-d55c-48fb-a022-060bdfac97ff@opensource.cirrus.com> (raw)
In-Reply-To: <sashiko-outbox-218869@kernel.org>

On 17/11/2026 1:23 pm, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:

It's so annoying that Sashiko only mails the review to the author and
one mailing list but not the maintainer or anyone else who was on the
original email it reviewed.

[...]

> [Severity: Medium]
> Can cs35l56_test_mock_registers_read() ever succeed on an unwritten ASP
> config or ASP mixer register when priv->registers is in cache-only mode and
> cs35l56_test_mock_reg_defaults has no entries for those ranges?
> 
> When the driver reads an uncached ASP register through cs35l56->base.regmap
> (for example during DAPM widget initialization), regmap_read(priv->registers,
> reg, &val) returns -EBUSY.  Because _regmap_read() only calls
> regcache_write() when map->reg_read() returns 0, the read fails to populate
> cs35l56->base.regmap's cache (and dapm_read() ignores the error), so the
> subsequent regcache_sync() calls in cs35l56_test_component_probe_omits_asp()
> will never flush those registers or set priv->asp_config_regs_written or
> priv->asp_mixer_regs_written.  Unchecked regmap_update_bits() calls on ASP
> registers also fail at the initial read before reaching
> cs35l56_test_mock_registers_write().

I _think_ this could be valid, but Gemini has a superhuman ability to
favour verbosity over clarity.



  reply	other threads:[~2026-11-17 14:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:59 [PATCH 0/2] ASoC: cs35l56: KUnit tests for ASP register write blocking Richard Fitzgerald
2026-11-17 12:59 ` [PATCH 1/2] ASoC: cs35l56: Add KUnit test that widget init doesn't write ASP registers Richard Fitzgerald
2026-11-17 13:23   ` sashiko-bot
2026-11-17 14:22     ` Richard Fitzgerald [this message]
2026-11-17 14:56       ` Mark Brown
2026-11-17 12:59 ` [PATCH 2/2] ASoC: cs35l56-shared: Add KUnit test cases for ASP config register writes Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa8c43bd-d55c-48fb-a022-060bdfac97ff@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox