Re: [PATCH v1 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCS8300 sound card

[Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>]

On 9/10/2025 1:09 PM, Krzysztof Kozlowski wrote:
> On 10/09/2025 09:26, Krzysztof Kozlowski wrote:
>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>>> index 8ac91625dce5..eebf80c1d79a 100644
>>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
>>> @@ -35,6 +35,7 @@ properties:
>>>             - qcom,qcm6490-idp-sndcard
>>>             - qcom,qcs6490-rb3gen2-sndcard
>>>             - qcom,qcs8275-sndcard
>>
>> So what is the point of this compatible? There is no user of it and I
>> think you added QCS8275 for this case exactly...
>>
>> Shall I start reverting commits from Qualcomm because you post patches
>> "just in case" and turns out they are completely not needed? No single
>> user of such code?
> 
> 
> @Mark,
> 
> In case it wasn't obvious, please do not merge the patch till we get
> some clarification. For sure it is wrong one way or another: either
> incomplete or just duplicated.
> 

The device tree currently uses qcs8275 as the sound compatible, and
the corresponding Device tree changes have already been applied and merged.

Reverting this now would break the ABI.

A new device tree patch with qcs8300 is currently under review:

https://lore.kernel.org/linux-arm-msm/20250910044512.1369640-1-mohammad.rafi.shaik@oss.qualcomm.com/

Once the machine driver and device tree patch with qcs8300 are accepted 
and merged,

I will promptly submit a cleanup patch to remove of discontinued 
compatibles from the machine driver.

> Best regards,
> Krzysztof