Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: Re: [PATCH 00/10] ASoC: wm_adsp: Some improvements to firmware file search
Date: Wed, 18 Mar 2026 10:27:15 +0000	[thread overview]
Message-ID: <abp+A18W3n720HQy@opensource.cirrus.com> (raw)
In-Reply-To: <abpw/f/3OPnjFW36@opensource.cirrus.com>

On Wed, Mar 18, 2026 at 09:31:41AM +0000, Charles Keepax wrote:
> On Tue, Mar 17, 2026 at 06:11:23PM +0000, Mark Brown wrote:
> > On Tue, Mar 17, 2026 at 05:47:19PM +0000, Charles Keepax wrote:
> > 
> > > The rabbit whole looks pretty deep on this one. As far as I can
> > > see it fails adding the device because the device already exists
> > > on the bus but this is the first time it added the device and also
> > > I can find no evidence it even created a bus in the first place.
> > > Feels like there is a large piece of my understanding of how
> > > this is supposed to work that is missing. I think we might have
> > > to wait for Richard to return on Monday, how much of a problem
> > > is that from your end?
> > 
> > This is holding inclusion of any new ASoC code since last Thursday out
> > of -next, that's pretty disruptive really.  It might be easiest to just
> > drop the changes and let Richard resubmit when he gets back.
> 
> Ok I will have a bit more of a gander today and chat to the boss
> here, but I suspect you are right we may have to revert the
> change. I will report back by end of today if not sooner.

Ok looking again with fresh eyes I think I have it. Turns out
most of my problems yesterday were just finding the right
incantations to get kunit to show me all the debug.

Patch incoming shortly.

Thanks,
Charles

  reply	other threads:[~2026-03-18 10:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-10 14:18 [PATCH 00/10] ASoC: wm_adsp: Some improvements to firmware file search Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 01/10] ASoC: wm_adsp: Remove unused argument to wm_adsp_release_firmware_files() Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 02/10] ASoC: wm_adsp: Add KUnit redirection stubs for firmware file search Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 03/10] ASoC: wm_adsp: Export function for KUnit test to get firmware filenames Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 04/10] ASoC: wm_adsp: Add kunit test for firmware file search Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 05/10] ASoC: wm_adsp: Remove duplicated code to find firmware file Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 06/10] ASoC: wm_adsp: Use consistent error checks in wm_adsp_request_firmware_files() Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 07/10] ASoC: wm_adsp: Convert '/' to '-' when normalizing firmware filenames Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 08/10] ASoC: wm_adsp: Add KUnit test cases for '/' in " Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 09/10] ASoC: wm_adsp: Use a struct to pass around firmware struct and filename Richard Fitzgerald
2026-03-10 14:18 ` [PATCH 10/10] ASoC: wm_adsp: Combine some similar code in firmware file search Richard Fitzgerald
2026-03-12 17:34 ` [PATCH 00/10] ASoC: wm_adsp: Some improvements to " Mark Brown
2026-03-13 14:58 ` Mark Brown
2026-03-17 15:37   ` Mark Brown
2026-03-17 15:52     ` Charles Keepax
2026-03-17 17:47       ` Charles Keepax
2026-03-17 18:11         ` Mark Brown
2026-03-18  9:31           ` Charles Keepax
2026-03-18 10:27             ` Charles Keepax [this message]
2026-03-18 11:15               ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abp+A18W3n720HQy@opensource.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rf@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox