Re: [PATCH v5 4/6] ASoC: SDCA: Create DAPM widgets and routes from DisCo

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 5/13/25 11:56, Charles Keepax wrote:
> On Mon, May 12, 2025 at 03:46:40PM +0200, Pierre-Louis Bossart wrote:
>> On 5/12/25 14:42, Charles Keepax wrote:
>> It's been a while since I reviewed an earlier versions so now I am confused.
> 
> I have attached the output of the dapm-graph tool for the UAJ
> component for one of our devices, whilst a headset is connected.
> Hopefully this will help to make it a little more clear what
> the generated graph from this code looks like. Hopefully the
> attachment makes it through the ether, let me know if it doesn't
> and I can send directly.
> 
> The PDE supply widgets are what control the PDE power registers,
> they will power up when they are attached to an active path, ie.
> a valid link between an active source and an active sink.
> 
> For the streaming terminals IT41,OT36 they are active when the
> audio stream is open. For the non-streaming ones
> IT31,IT32,IT33,OT43,OT44,OT45 these are active when the pin
> switch is enabled which it is by default, without pin switches
> these would be always active. The pin switches are not shown
> on the output of dapm-graph.
> 
> You can see the effect of the GE control, where it has set the
> input of SU35 to FU33, by the selection of "Headset". And you can
> see the virtual mixer switches going into MU35, currently both
> Mixer 1 and 2 are on, so you can see the paths connected.
> 
> But as you can see the correlation to the function diagrams is
> the spec is pretty good. As I noted with a few minor exceptions,
> like the GE having more paths, since it must connect to all the
> widgets it controls separately. And the DAI widgets that are
> created by the DAPM core.

Thanks for the diagram, very useful indeed.

The only comment I'd have is that all SUs are represented as MUXes in this DAPM graph, but in practice most of them are simple on/off switches. The case of SU35 is one of the exceptions to the rule where it can have multiple inputs. I don't really mind if all SUs are represented as MUX, but it's not a direct mapping from the SDCA spec.