Re: [PATCH 1/2] ASoC: SDCA: remove the max count of initialization table

Charles Keepax
2026-03-25T10:59:00Z

On Wed, Mar 25, 2026 at 10:51:24AM +0000, Shuming [范書銘] wrote:
> > On Wed, Mar 25, 2026 at 05:20:17PM +0800, shumingf@realtek.com wrote:
> > > From: Shuming Fan <shumingf@realtek.com>
> > > The number of the initialization table may exceed 2048.
> > > Therefore, this patch removes the limitation and allows the driver to
> > > allocate memory dynamically based on the size of the initialization table.
> >
> > We were concerned this might be a little too low. Are we sure we want to
> > remove the limit rather than just increasing the allowed size? I feel like I can
> > see arguments for both ways, on one hand this is input to the driver rather
> > than part of it so it feels sensible to sanity check it, on the other hand its the
> > BIOS so really we should be able to trust that.
>
> I think we should trust the BIOS.
> If the BIOS is updated, the number may increase.
> It's difficult to define a fixed value for this argument.

Alright, lets go with that then.

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles