From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: shumingf@realtek.com
Cc: broonie@kernel.org, lgirdwood@gmail.com,
linux-sound@vger.kernel.org, lars@metafoo.de, flove@realtek.com,
oder_chiou@realtek.com, jack.yu@realtek.com,
derek.fang@realtek.com
Subject: Re: [PATCH 1/2] ASoC: SDCA: remove the max count of initialization table
Date: Wed, 25 Mar 2026 10:00:25 +0000 [thread overview]
Message-ID: <acOyOZ4fxUoQ0p5L@opensource.cirrus.com> (raw)
In-Reply-To: <20260325092017.3221640-1-shumingf@realtek.com>
On Wed, Mar 25, 2026 at 05:20:17PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
>
> The number of the initialization table may exceed 2048.
> Therefore, this patch removes the limitation and allows the driver to
> allocate memory dynamically based on the size of the initialization table.
We were concerned this might be a little too low. Are we sure we
want to remove the limit rather than just increasing the allowed
size? I feel like I can see arguments for both ways, on one hand
this is input to the driver rather than part of it so it feels
sensible to sanity check it, on the other hand its the BIOS so
really we should be able to trust that.
Thanks,
Charles
next prev parent reply other threads:[~2026-03-25 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 9:20 [PATCH 1/2] ASoC: SDCA: remove the max count of initialization table shumingf
2026-03-25 10:00 ` Charles Keepax [this message]
2026-03-25 10:51 ` Shuming [范書銘]
2026-03-25 10:58 ` Charles Keepax
2026-03-25 12:22 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acOyOZ4fxUoQ0p5L@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox