From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF1736308A; Fri, 27 Mar 2026 16:48:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774630085; cv=none; b=Ui4GM8hXXoDHHsTKAlrPyu3yuWZvJ1xCK9S4pe/qHkHAxaKXhNM7j74ZigRioJlePldyaLrs2j3iB5WlhThjT71+ujnDrr16iS4965PAp5crsaro59vtQxfiou0Tm8P/4ZFtBiwcRWVU3xe+m8iWNPL85GMhbU10KFySbLyYMGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774630085; c=relaxed/simple; bh=d3PijMvDbvxnUEzU6gxuyBsPTheOglT+TbYXjvUHlxo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iU02vzkwIEdvP8Xiv9cjkCacV+lI+l/bHbODUSoeo0f8/kVhVD8OUtuIa0z4AijCWienQ6+7Ng7PY/9COoXRaRs/NNwGpz2jgTitz5ga9tDNHqm0VO8mUUyet/WKnBxR8nKgycdDodPVaKaOpL6i79Do42mCBSEOU+YZIrxqUps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FHnbF2XL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FHnbF2XL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F9C2C2BCB0; Fri, 27 Mar 2026 16:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774630084; bh=d3PijMvDbvxnUEzU6gxuyBsPTheOglT+TbYXjvUHlxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FHnbF2XLg1VpyGIZjp0fO1fyXZ247/0Qx4/UQ8rQAVd/KGIBOhagbnA0bTyP6g9cy 6t4/LwHmYL7m1UYXLtYpWzAuNHv6ylaWaq+eucABINGOC0orQoNHJKx8HUCfVo+6uz Is5R7E8vOErjYJmacjGSP5qRgWu4+Wdr9zYL4QceQyfg4dHThlMfeGVsPk3gE/dxAe BXLtndhV16gmg+79HMYObz+j9v8qeseCJsB/LHAbPy9PVa63yIcEDa+tnZO3HVIOBH kCkgW4TPxFD+LwDV8JAAAaE5eaWt5KtexV8supiFW3XTd71IgEJIK5mou+RNU0XkVH o0rro4PxEOf7g== Received: by finisterre.sirena.org.uk (Postfix, from userid 1000) id E20141AC5731; Fri, 27 Mar 2026 16:48:00 +0000 (GMT) Date: Fri, 27 Mar 2026 16:48:00 +0000 From: Mark Brown To: "Liao, Bard" Cc: Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Pierre-Louis Bossart , Jaroslav Kysela , Takashi Iwai , Paul Olaru , Laurentiu Mihalcea , "sound-open-firmware@alsa-project.org" , "linux-sound@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH] ASoC: SOF: Don't allow pointer operations on unconfigured streams Message-ID: References: <20260326-asoc-compress-tstamp-params-v1-1-3dc735b3d599@kernel.org> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6ZUEPrAzetSX6Z5N" Content-Disposition: inline In-Reply-To: X-Cookie: Identify your visitor. --6ZUEPrAzetSX6Z5N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 27, 2026 at 02:09:40AM +0000, Liao, Bard wrote: > > + if (!sstream->channels || !sstream->sample_container_bytes) > > + return -EBUSY; > Sorry, but why it is BUSY in this case? -EBUSY is often "wrong state". Could also be -EINVAL, it doesn't super make a difference I think - nobody should actually be doing this. --6ZUEPrAzetSX6Z5N Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmnGtMAACgkQJNaLcl1U h9CaJQf+IVjaqUbzUXV6gRp5wytogHz5dvAUlo/Fe3LMGpzH8kzUtnyNJQ+ACcpG 2RnFIOgX6s6Xnw+i/f02rCj/mKAKbana+RDJLbBi5/qgQSUmsvzKJv9nbhTz1+QM cYdJ2YBwglKvxdMACR3yX//zYaHeLPSelQ4GmwTh2y+JcV3hyayRkZv5/drDoFID Ko0oBWAZxerqpPMzq+NmMTl+D4ftEMTZkfjL9ukQ7qHirXgMmreor38/1YSL4nFT H45AME+nE4LSccbuHqMlL4eMswXBwKYKBPT8QIj3Lv9AS4hmhEpj8a8/aytBvyrY rtV1zogwH51/VelCkjtydq1gD6HSiA== =2Sv+ -----END PGP SIGNATURE----- --6ZUEPrAzetSX6Z5N--