public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: aravindanilraj0702@gmail.com
Cc: linux-sound@vger.kernel.org, cezary.rojewski@intel.com,
	liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com,
	yung-chuan.liao@linux.intel.com,
	ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
	pierre-louis.bossart@linux.dev, perex@perex.cz, tiwai@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] ASoC: Intel: Fix MCLK leaks in platform_clock_control
Date: Fri, 27 Mar 2026 21:06:39 +0000	[thread overview]
Message-ID: <acbxX-8PPcXg5y1C@sirena.co.uk> (raw)
In-Reply-To: <20260327210408.430908-1-aravindanilraj0702@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

On Fri, Mar 27, 2026 at 05:04:05PM -0400, aravindanilraj0702@gmail.com wrote:
> From: Aravind Anilraj <aravindanilraj0702@gmail.com>
> 
> In three Intel ASoC board drivers, the EVENT_ON path in
> platform_clock_control() enables MCLK using clk_prepare_enable(), but
> error paths fail to call clk_disable_unprepare(), leaking a clock
> reference.

Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.

Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed.  Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing.  If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2026-03-27 21:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 19:29 [PATCH 0/3] ASoC: Intel: Fix MCLK leaks in aravindanilraj0702
2026-03-27 19:30 ` [PATCH 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error aravindanilraj0702
2026-03-27 19:30 ` [PATCH 2/3] ASoC: Intel: bytcr_rt5651: " aravindanilraj0702
2026-03-27 20:10   ` Mark Brown
2026-03-27 19:30 ` [PATCH 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control aravindanilraj0702
2026-03-27 20:11   ` Mark Brown
2026-03-27 20:13 ` [PATCH v2 0/3] ASoC: Intel: Fix MCLK leaks in aravindanilraj0702
2026-03-27 20:13   ` [PATCH v2 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error aravindanilraj0702
2026-03-27 20:13   ` [PATCH v2 2/3] ASoC: Intel: bytcr_rt5651: " aravindanilraj0702
2026-03-27 20:13   ` [PATCH v2 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control aravindanilraj0702
2026-03-27 21:04 ` [PATCH v3 0/3] ASoC: Intel: Fix MCLK leaks " aravindanilraj0702
2026-03-27 21:04   ` [PATCH v3 1/3] ASoC: Intel: bytcr_rt5640: Fix MCLK leak on platform_clock_control error aravindanilraj0702
2026-03-27 21:04   ` [PATCH v3 2/3] ASoC: Intel: bytcr_rt5651: " aravindanilraj0702
2026-03-27 21:04   ` [PATCH v3 3/3] ASoC: Intel: cht_bsw_rt5672: Fix MCLK leak in platform_clock_control aravindanilraj0702
2026-03-27 21:06   ` Mark Brown [this message]
2026-03-28  6:19     ` [PATCH v3 0/3] ASoC: Intel: Fix MCLK leaks " Aravind
2026-04-09 22:03 ` [PATCH 0/3] ASoC: Intel: Fix MCLK leaks in Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acbxX-8PPcXg5y1C@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=aravindanilraj0702@gmail.com \
    --cc=cezary.rojewski@intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox