From: Mark Brown <broonie@kernel.org>
To: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org
Subject: Re: [RFC][PATCH 0/3] ASoC: remove card->pop_time
Date: Thu, 9 Apr 2026 20:11:12 +0100 [thread overview]
Message-ID: <adf50GLs7me92fvV@sirena.co.uk> (raw)
In-Reply-To: <82c256e5-0af8-4ea3-ba5a-913a576b25cd@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Thu, Apr 09, 2026 at 11:14:08AM +0300, Péter Ujfalusi wrote:
> On 09/04/2026 07:36, Kuninori Morimoto wrote:
> > I'm now trying to cleanup snd_soc_card, and noticed that card->pop_time is used
> > only from OMAP1 board-ams-delta.
> The pop_time is an amazingly good tool to debug pop noise and is mostly
> used via the debugfs.
> You set the pop_time to non 0 and DAPM will 'slow down' and you can
> identify the step which produces the pop.
> Please, don't remove it!
For Morimoto-san's purposes I think it's sufficient to just make it not
card specific so we could just have a global control in debugfs that
applies to all cards instead. That's likely sufficient for debugging
use?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-09 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 4:36 [RFC][PATCH 0/3] ASoC: remove card->pop_time Kuninori Morimoto
2026-04-09 4:37 ` [RFC][PATCH 1/3] ASoC: ti: amx-delta: don't use card->pop_time Kuninori Morimoto
2026-04-09 4:37 ` [RFC][PATCH 2/3] ASoC: cx20442: " Kuninori Morimoto
2026-04-09 4:37 ` [RFC][PATCH 3/3] ASoC: soc-card: remvoe card->pop_time Kuninori Morimoto
2026-04-09 5:22 ` [RFC][PATCH 0/3] ASoC: remove card->pop_time Takashi Iwai
2026-04-09 20:47 ` Mark Brown
2026-04-09 8:14 ` Péter Ujfalusi
2026-04-09 19:11 ` Mark Brown [this message]
2026-04-10 3:14 ` Kuninori Morimoto
2026-04-10 7:06 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adf50GLs7me92fvV@sirena.co.uk \
--to=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox