Re: [RFC][PATCH 0/3] ASoC: remove card->pop_time

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On Thu, Apr 09, 2026 at 07:22:22AM +0200, Takashi Iwai wrote:
> Kuninori Morimoto wrote:

> > With off-list talk with Mark, this card->pop_time is is much less of a
> > problem.

> Hmm, are you sure?  IIUC, it's used for a flag in the modem desc for
> cx81801, and a bunch of setup seems depending on it, and your second
> patch removes the whole of those without alternative.

> > So let's remove it. But it needs Acked-by from OMAP1 member.
> > I added [RFC] on Subject.

> So the actual question is whether the modem is utterly broken for this
> hardware or not.  If yes, it'd be a good reason to drop and apply this
> cleanup.

> But if it's not, we'd need an alternative implementation, e.g. move
> the flag and its handling to the modem's own object instead of the
> ASoC core, instead.

Yeah, we need to figure out if there's any actual users of this still
and if so how are they using it.  It looks like you need some custom
userspace to drive them model which is fun...  There's also some
more references to the timer which need to be cleaned up/updated if the
setup is removed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]