Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Alexey Klimov <alexey.klimov@linaro.org>,
	broonie@kernel.org, konradybcio@kernel.org,
	konrad.dybcio@oss.qualcomm.com, andersson@kernel.org,
	srinivas.kandagatla@linaro.org
Cc: tiwai@suse.com, lgirdwood@gmail.com, perex@perex.cz,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	dmitry.baryshkov@linaro.org, linux-sound@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210
Date: Thu, 12 Dec 2024 18:22:25 +0100	[thread overview]
Message-ID: <ae57068c-5d73-459d-b319-46a582ed7f3e@oss.qualcomm.com> (raw)
In-Reply-To: <20241212004727.2903846-15-alexey.klimov@linaro.org>

On 12.12.2024 1:47 AM, Alexey Klimov wrote:
> In case of mono configurations we need to enforce single channel
> output. This is required for audio playback on QRB4210 RB2 board
> since it has only one WSA8815 amplifier.
> Implement data variant for qrb4210-rb2-sndcard with
> sm8250_qrb4210_fixup_params() that does that.
> 
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---

Would it not be enough to set channels->min = 1?

Konrad

  reply	other threads:[~2024-12-12 17:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12  0:47 [PATCH v2 00/14] qrb4210-rb2: add wsa audio playback and capture support Alexey Klimov
2024-12-12  0:47 ` [PATCH v2 01/14] ASoC: dt-bindings: qcom: Add SM6115 LPASS rxmacro and vamacro codecs Alexey Klimov
2024-12-12  2:25   ` Rob Herring (Arm)
2024-12-12  7:39   ` Krzysztof Kozlowski
2024-12-12 16:36   ` Konrad Dybcio
2024-12-12  0:47 ` [PATCH v2 02/14] ASoC: codecs: va-macro: add sm6115 compatible Alexey Klimov
2024-12-12  7:40   ` Krzysztof Kozlowski
2024-12-12  0:47 ` [PATCH v2 03/14] ASoC: codecs: lpass-rx-macro: " Alexey Klimov
2024-12-12  0:47 ` [PATCH v2 04/14] arm64: dts: qcom: sm6115: add LPASS devices Alexey Klimov
2024-12-12  7:42   ` Krzysztof Kozlowski
2024-12-12  0:47 ` [PATCH v2 05/14] arm64: dts: qcom: sm4250: add description of soundwire and dmic pins Alexey Klimov
2024-12-12  0:47 ` [PATCH v2 06/14] arm64: dts: qcom: qrb4210-rb2: add wcd937x codec support Alexey Klimov
2024-12-12  7:43   ` Krzysztof Kozlowski
2024-12-12 17:17   ` Konrad Dybcio
2024-12-12  0:47 ` [PATCH v2 07/14] ASoC: codecs: wsa881x: split into common and soundwire drivers Alexey Klimov
2024-12-12 17:20   ` Konrad Dybcio
2024-12-12  0:47 ` [PATCH v2 08/14] dt-bindings: arm: qcom-soc: extend pattern matching to support qcom,wsa881x Alexey Klimov
2024-12-12  7:46   ` Krzysztof Kozlowski
2024-12-12  8:02     ` Krzysztof Kozlowski
2024-12-12  0:47 ` [PATCH v2 09/14] ASoC: dt-bindings: qcom,wsa881x: extend description to analog mode Alexey Klimov
2024-12-12  2:25   ` Rob Herring (Arm)
2024-12-12  7:49   ` Krzysztof Kozlowski
2024-12-12 16:39   ` Konrad Dybcio
2024-12-12  0:47 ` [PATCH v2 10/14] arm64: dts: qcom: qrb4210-rb2: enable wsa881x amplifier Alexey Klimov
2024-12-12  0:47 ` [PATCH v2 11/14] ASoC: codecs: add wsa881x-i2c amplifier codec driver Alexey Klimov
2024-12-12  0:47 ` [PATCH v2 12/14] arm64: dts: qcom: qrb4210-rb2: add WSA audio playback support Alexey Klimov
2024-12-13 12:41   ` Konrad Dybcio
2024-12-12  0:47 ` [PATCH v2 13/14] arm64: dts: qcom: qrb4210-rb2: add VA capture support Alexey Klimov
2024-12-12  0:47 ` [PATCH v2 14/14] ASoC: qcom: sm8250: force single channel via RX_1 output for qrb4210 Alexey Klimov
2024-12-12 17:22   ` Konrad Dybcio [this message]
2024-12-13 11:54     ` Alexey Klimov
2024-12-13 11:57       ` Konrad Dybcio
2024-12-12  7:37 ` [PATCH v2 00/14] qrb4210-rb2: add wsa audio playback and capture support Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae57068c-5d73-459d-b319-46a582ed7f3e@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=alexey.klimov@linaro.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox