From: Mark Brown <broonie@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-sound@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: ti: j721e-evm: allocate dai_links with priv
Date: Tue, 28 Apr 2026 12:58:31 +0900 [thread overview]
Message-ID: <afAwZ7vl9bRtmLsa@sirena.co.uk> (raw)
In-Reply-To: <20260427051953.956372-1-rosenp@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On Sun, Apr 26, 2026 at 10:19:53PM -0700, Rosen Penev wrote:
> Remove open coding of of_device_get_match_data as well as unnecessary
> NULL checks. of_device_get_match_data cannot fail. All compatible
> entries have a corresponding data section.
of_device_get_match_data() can fail if there is no match data, for
example because someone is using sysfs to try to instantiate rather than
instantiating from device tree. There is no reason to take out the
error handling here, it just makes things less robust.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-04-28 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 5:19 [PATCH] ASoC: ti: j721e-evm: allocate dai_links with priv Rosen Penev
2026-04-28 3:58 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afAwZ7vl9bRtmLsa@sirena.co.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@gmail.com \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox