From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: Niranjan H Y <niranjan.hy@ti.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
cezary.rojewski@intel.com, peter.ujfalusi@linux.intel.com,
yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
pierre-louis.bossart@linux.dev, baojun.xu@ti.com,
shenghao-ding@ti.com, sandeepk@ti.com, v-hampiholi@ti.com
Subject: Re: [PATCH v11 1/4] ASoC: SDCA: Add PDE verification reusable helper
Date: Tue, 28 Apr 2026 13:05:11 +0100 [thread overview]
Message-ID: <afCidxvz5oVrmzHM@opensource.cirrus.com> (raw)
In-Reply-To: <afADP5lPtcG13RTr@sirena.co.uk>
On Tue, Apr 28, 2026 at 09:45:51AM +0900, Mark Brown wrote:
> On Mon, Apr 27, 2026 at 01:53:58PM +0530, Niranjan H Y wrote:
>
> > + dev_err(dev, "PDE power transition failed: expected 0x%x, got 0x%x\n", to_ps, val);
>
> The old code included entity->label, I guess for disambiguation?
Hmm... yeah I think perhaps we should push the error message up
to the caller here as it will have better context to print the
message.
>
> > + return -ETIMEDOUT;
> > +}
> > +EXPORT_SYMBOL(sdca_asoc_pde_poll_actual_ps);
>
> All the other SDCA stuff seems to use EXPORT_SYMBOL_NS() or
> EXPORT_SYMBOL_NS_GPL()?
Oh thanks yeah that is a good spot, we should fix that up.
Thanks,
Charles
prev parent reply other threads:[~2026-04-28 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 8:23 [PATCH v11 1/4] ASoC: SDCA: Add PDE verification reusable helper Niranjan H Y
2026-04-27 8:23 ` [PATCH v11 2/4] ASoC: tac5xx2-sdw: add soundwire based codec driver Niranjan H Y
2026-04-28 0:52 ` Mark Brown
2026-04-28 19:57 ` Pierre-Louis Bossart
2026-04-27 8:24 ` [PATCH v11 3/4] ASoC: sdw_utils: TI amp utility for tac5xx2 family Niranjan H Y
2026-04-27 8:24 ` [PATCH v11 4/4] ASoC: tac5xx2-sdw: ACPI match for intel mtl platform Niranjan H Y
2026-04-27 8:47 ` [PATCH v11 1/4] ASoC: SDCA: Add PDE verification reusable helper Charles Keepax
2026-04-28 0:45 ` Mark Brown
2026-04-28 12:05 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afCidxvz5oVrmzHM@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sandeepk@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=v-hampiholi@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox